From owner-cvs-all@FreeBSD.ORG  Thu Oct 28 17:51:44 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 08B6916A4D6; Thu, 28 Oct 2004 17:51:44 +0000 (GMT)
Received: from obsecurity.dyndns.org
	(CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.194.102.143])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D0C2A43D5D; Thu, 28 Oct 2004 17:51:43 +0000 (GMT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 20D83511A7; Thu, 28 Oct 2004 10:52:57 -0700 (PDT)
Date: Thu, 28 Oct 2004 10:52:57 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Dirk Meyer <dinoex@FreeBSD.org>
Message-ID: <20041028175256.GB67234@xor.obsecurity.org>
References: <200410281708.i9SH8rDZ094833@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pvezYHf7grwyp3Bc"
Content-Disposition: inline
In-Reply-To: <200410281708.i9SH8rDZ094833@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/x11-toolkits/tk84 Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Oct 2004 17:51:48 -0000


--pvezYHf7grwyp3Bc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 28, 2004 at 05:08:53PM +0000, Dirk Meyer wrote:
> dinoex      2004-10-28 17:08:53 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     x11-toolkits/tk84    Makefile=20
>   Log:
>   - detect unsupported configuration

It is supported, so this commit is incorrect too.  Please take the
time to think through the problem, including the feedback you've
received, instead of making a rash of broken commits in your haste to
fix it.  Testing your changes would also be good.

Kris

> | +TCL_CHECK!=3D	( cd ${PORTSDIR}/${PKGCATEGORY}/${TCL84_PORT} && make WR=
KDIRPREFIX=3D -V WRKSRC | sed -e 's|/unix$$||' )
> | +
> |  pre-everything::
> |  	@if ${TEST} -e "${NONEXISTENT}"; then ${ECHO_MSG} "=3D=3D=3D Aborted,=
 please remove ${NONEXISTENT}"; exit 1; fi
> | =20
> | @@ -366,6 +368,7 @@ post-configure:
> |  	${REINPLACE_CMD} -e 's|^MAN_INSTALL_DIR.*$$|MAN_INSTALL_DIR =3D ${WRK=
DIR}|' \
> |  		${WRKSRC}/Makefile
> |  .endif
> | +	@if ! grep "TCL_SRC_DIR=3D.\$${WRKDIRPREFIX}${TCL_CHECK}" "${LOCALBAS=
E}/lib/tcl8.4/tclConfig.sh"; then ${ECHO_MSG} "=3D=3D=3D Aborted, this conf=
iguration is not supported, set PORTSDIR and rebuild tcl84"; exit 1; fi
> | =20
> |  post-install:
> |  	${INSTALL_DATA} ${FILESDIR}/pkgIndex.tcl ${PREFIX}/lib/tk${TK_VER}/
>=20

--pvezYHf7grwyp3Bc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBgTH4Wry0BWjoQKURAkXpAKDkD22WOEYeh2XAacMLU+vP9valKACfTxNK
cAhkxisD6e5kYQxUIJgpuaQ=
=laTB
-----END PGP SIGNATURE-----

--pvezYHf7grwyp3Bc--