From owner-cvs-src@FreeBSD.ORG Fri Nov 14 12:31:10 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 674CD16A4CE; Fri, 14 Nov 2003 12:31:10 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DD8543F75; Fri, 14 Nov 2003 12:31:03 -0800 (PST) (envelope-from sam@errno.com) Received: from 66.127.85.91 ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id hAEKV10x040517 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 14 Nov 2003 12:31:02 -0800 (PST) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Nate Lawson , Sam Leffler Date: Fri, 14 Nov 2003 12:33:14 -0800 User-Agent: KMail/1.5.3 References: <20031114190111.EDAC816A4E2@hub.freebsd.org> <20031114121752.V48322@root.org> In-Reply-To: <20031114121752.V48322@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200311141233.14513.sam@errno.com> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/an if_an.c if_anreg.h src/sys/dev/bfe if_bfe.c src/sys/dev/my if_my.c src/sys/dev/owi if_owi.c if_wivar.h src/sys/dev/re if_re.c src/sys/dev/wl if_wl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2003 20:31:10 -0000 On Friday 14 November 2003 12:21 pm, Nate Lawson wrote: > On Fri, 14 Nov 2003, Sam Leffler wrote: > > Modified files: > > sys/dev/an if_an.c if_anreg.h > > sys/dev/bfe if_bfe.c > > sys/dev/my if_my.c > > sys/dev/owi if_owi.c if_wivar.h > > sys/dev/re if_re.c > > sys/dev/wl if_wl.c > > sys/pci if_dc.c if_dcreg.h if_pcn.c if_pcnreg.h > > if_rl.c if_rlreg.h if_sf.c if_sfreg.h > > if_sis.c if_sisreg.h if_sk.c if_skreg.h > > if_ste.c if_stereg.h if_ti.c if_tireg.h > > if_tl.c if_tlreg.h if_vr.c if_vrreg.h > > if_wb.c if_wbreg.h if_xl.c if_xlreg.h > > Log: > > Drop the driver lock around calls to if_input to avoid a LOR when > > the packets are immediately returned for sending (e.g. when bridging > > or packet forwarding). There are more efficient ways to do this > > but for now use the least intrusive approach. > > > > Reviewed by: imp, rwatson > > FYI, I believe fxp(4) already has this fix. Yes, several drivers already do this; I just did a sweep through the remaining drivers that were locked to make them all do the same thing. Sam