Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Mar 2021 14:05:06 -0600
From:      Kyle Evans <kevans@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org
Subject:   Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c.
Message-ID:  <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w@mail.gmail.com>
In-Reply-To: <202103051755.125HtZsc073704@gitrepo.freebsd.org>
References:  <202103051755.125HtZsc073704@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 5, 2021 at 11:55 AM John Baldwin <jhb@freebsd.org> wrote:
>
> The branch main has been updated by jhb:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff
>
> commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2021-03-05 17:47:58 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2021-03-05 17:55:11 +0000
>
>     poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c.
>
>     There currently isn't a need to provide a public interface to a
>     software Poly1305 implementation beyond what is already available via
>     libsodium's APIs and these symbols conflict with symbols shared within
>     the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c.
>
>     Reported by:    se, kp
>     Fixes:          78991a93eb9d
>     Sponsored by:   Netflix
> ---
>  sys/opencrypto/xform_poly1305.c | 43 ++++++++++++-----------------------------
>  sys/opencrypto/xform_poly1305.h | 16 ---------------
>  2 files changed, 12 insertions(+), 47 deletions(-)

xform_poly1305.h also needs to stop being grouped in
^/include/Makefile (reported by jenkins via np)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w>