From owner-svn-src-all@freebsd.org Thu Jul 19 19:53:03 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E4331047A00; Thu, 19 Jul 2018 19:53:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C75A77756A; Thu, 19 Jul 2018 19:53:02 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id A6B29179D; Thu, 19 Jul 2018 19:53:02 +0000 (UTC) Date: Thu, 19 Jul 2018 19:53:02 +0000 From: Alexey Dokuchaev To: Michael Tuexen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 Message-ID: <20180719195302.GA26853@FreeBSD.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201807191933.w6JJXhof018383@repo.freebsd.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 19:53:03 -0000 On Thu, Jul 19, 2018 at 07:33:43PM +0000, Michael Tuexen wrote: > New Revision: 336503 > URL: https://svnweb.freebsd.org/changeset/base/336503 > > Log: > Whitespace changes due to change if ident. Was it reviewed? Commit log does not answer this not does it explain why these changes are good. > +++ head/sys/netinet/sctp.h Thu Jul 19 19:33:42 2018 (r336503) > @@ -419,7 +419,7 @@ struct sctp_error_unresolv_addr { > > struct sctp_error_unrecognized_chunk { > struct sctp_error_cause cause; /* code=SCTP_CAUSE_UNRECOG_CHUNK */ > - struct sctp_chunkhdr ch;/* header from chunk in error */ > + struct sctp_chunkhdr ch; /* header from chunk in error */ This feems fine. > +++ head/sys/netinet/sctp_asconf.c Thu Jul 19 19:33:42 2018 (r336503) > static struct mbuf * > -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t *error_tlv, > +sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t * error_tlv, This looks strange now. In C, asterisk is usually placed by the variable. > - tlv = (uint8_t *)(error + 1); > + tlv = (uint8_t *) (error + 1); Are we doing this now? style(9) suggests otherwise. > - p_addr = (struct sctp_ipv6addr_param *)sctp_m_getptr(m, offset, sizeof(struct sctp_paramhdr), (uint8_t *)&aparam_buf); > + p_addr = (struct sctp_ipv6addr_param *)sctp_m_getptr(m, offset, sizeof(struct sctp_paramhdr), (uint8_t *) & aparam_buf); Ouch! This looks king of ugly now. :-/ > @@ -816,8 +821,7 @@ send_reply: > * does the address match? returns 0 if not, 1 if so > */ > static uint32_t > -sctp_asconf_addr_match(struct sctp_asconf_addr *aa, struct sockaddr *sa) > -{ > +sctp_asconf_addr_match(struct sctp_asconf_addr *aa, struct sockaddr *sa){ This and similar cases below are just plain wrong. :-( ./danfe