Date: Mon, 7 Feb 2022 14:31:49 -0700 From: Warner Losh <imp@bsdimp.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Sebastian Huber <sebastian.huber@embedded-brains.de>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: ntp_init() looks like a nop Message-ID: <CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw@mail.gmail.com> In-Reply-To: <202202072032.217KWUdU085792@critter.freebsd.dk> References: <ac806cf6-a17f-77ba-5633-0c95eda1f8cf@embedded-brains.de> <202202072032.217KWUdU085792@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000bba63305d77454bc Content-Type: text/plain; charset="UTF-8" On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: > -------- > Sebastian Huber writes: > > > The ntp_init() function sets a couple of global variables to zero. > These=20 > > variables should be in the .bss section. Are they not already cleared=20 > > during the kernel loading? > > They are, but I kept the code to minimize the diff relative to Dave Mills > original version of the code. > > It can go no. > I think I lost the email race. I just pushed Sebastian's changes. Is this a request to not do this? If so, I'll revert. Warner --000000000000bba63305d77454bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Mon, Feb 7, 2022 at 1:34 PM Poul-H= enning Kamp <<a href=3D"mailto:phk@phk.freebsd.dk">phk@phk.freebsd.dk</a= >> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px= 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---= -----<br> Sebastian Huber writes:<br> <br> > The ntp_init() function sets a couple of global variables to zero. The= se=3D20<br> > variables should be in the .bss section. Are they not already cleared= =3D20<br> > during the kernel loading?<br> <br> They are, but I kept the code to minimize the diff relative to Dave Mills<b= r> original version of the code.<br> <br> It can go no.<br></blockquote><div><br></div><div>I think I lost the email = race. I just pushed Sebastian's changes. Is this a request to not do th= is? If so, I'll revert.</div><div><br></div><div>Warner=C2=A0</div></di= v></div> --000000000000bba63305d77454bc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw>