Date: Wed, 19 May 2004 23:33:44 +0800 (CST) From: Yen-Ming Lee <leeym@utopia.leeym.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/66891: update port: devel/portlint Message-ID: <20040519153344.617E83EA33C@utopia.leeym.com> Resent-Message-ID: <200405191540.i4JFeKHl048965@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 66891
>Category: ports
>Synopsis: update port: devel/portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed May 19 08:40:20 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator: Yen-Ming Lee
>Release: FreeBSD 5.2.1-RELEASE-p6 i386
>Organization:
>Environment:
System: FreeBSD utopia.leeym.com 5.2.1-RELEASE-p6 FreeBSD 5.2.1-RELEASE-p6 #94: Mon May 17 05:16:45 CST 2004 root@utopia.leeym.com:/usr/obj/usr/src/sys/UTOPIA i386
>Description:
portlint complains about 'please use USE_LIBTOOL in Makefile if possible' even if USE_LIBTOOL is set already.
>How-To-Repeat:
>Fix:
--- portlint.diff begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.57
diff -u -r1.57 portlint.pl
--- src/portlint.pl 1 May 2004 02:25:00 -0000 1.57
+++ src/portlint.pl 19 May 2004 15:30:29 -0000
@@ -173,7 +173,7 @@
PKGNAMESUFFIX DISTNAME DISTFILES CATEGORIES MASTERDIR MAINTAINER
MASTER_SITES WRKDIR WRKSRC NO_WRKSUBDIR PATCHDIR SCRIPTDIR FILESDIR
PKGDIR COMMENT DESCR PLIST PKGCATEGORY PKGINSTALL PKGDEINSTALL
- PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB
+ PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB USE_LIBTOOL
);
my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist);
@@ -678,7 +678,7 @@
"disallowed.");
}
- if ($_ =~ /\.la$/) {
+ if ($_ =~ /\.la$/ && $makevar{USE_LIBTOOL} eq '') {
&perror("WARN: $file [$.]: installing libtool archives, ".
"please use USE_LIBTOOL in Makefile if possible");
}
--- portlint.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040519153344.617E83EA33C>