Date: Mon, 28 Apr 2003 16:49:25 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "Alan L. Cox" <alc@imimic.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/osf1 osf1_signal.c Message-ID: <XFMail.20030428164925.jhb@FreeBSD.org> In-Reply-To: <3EAD744C.981EB57B@imimic.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28-Apr-2003 Alan L. Cox wrote: > John Baldwin wrote: >> >> On 26-Apr-2003 Alan L. Cox wrote: >> > John Baldwin wrote: >> >> >> >> jhb 2003/04/25 12:52:30 PDT >> >> >> >> FreeBSD src repository >> >> >> >> Modified files: >> >> sys/alpha/osf1 osf1_signal.c >> >> Log: >> >> Lock Giant around calls to useracc() in osf1_sigreturn() so that the >> >> function is MP safe. >> >> >> >> Revision Changes Path >> >> 1.31 +5 -1 src/sys/alpha/osf1/osf1_signal.c >> > >> > The calls to useracc() should simply be eliminated because they are >> > redundant. See, for example, any of the implementations of sigreturn in >> > alpha/alpha/machdep.c. >> >> I don't mind if they are removed. :) >> > > Is that a subtle suggestion for me to do it? :-) Heh, if you want. At the moment I'm working on pushing Giant down (or eradicating it) from syscalls centered around process things such as signalling, etc. I figured the useracc() checks could be axed but chose to play it safe. I'd rather have someone more knowledgeable in the VM area axe them. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030428164925.jhb>