Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Sep 2012 23:38:43 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r240698 - head/cddl/contrib/opensolaris/cmd/zfs
Message-ID:  <20120920213843.GQ26107@ithaqua.etoilebsd.net>
In-Reply-To: <20120920211701.GD1407@garage.freebsd.pl>
References:  <201209191628.q8JGSckQ025683@svn.freebsd.org> <20120920211701.GD1407@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help

--Y9o+fgG4MNl0mnzl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 20, 2012 at 11:17:01PM +0200, Pawel Jakub Dawidek wrote:
> On Wed, Sep 19, 2012 at 04:28:38PM +0000, Baptiste Daroussin wrote:
> > Author: bapt
> > Date: Wed Sep 19 16:28:38 2012
> > New Revision: 240698
> > URL: http://svn.freebsd.org/changeset/base/240698
> >=20
> > Log:
> >   Update usage to show the possiblity to use jail name
> >  =20
> >   Reported by:	bdrewery
> >   MFC after:	1 month
> >=20
> > Modified:
> >   head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
> >=20
> > Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c	Wed Sep 19 16:21:2=
3 2012	(r240697)
> > +++ head/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c	Wed Sep 19 16:28:3=
8 2012	(r240698)
> > @@ -240,9 +240,9 @@ get_usage(zfs_help_t idx)
> >  		return (gettext("\tupgrade [-v]\n"
> >  		    "\tupgrade [-r] [-V version] <-a | filesystem ...>\n"));
> >  	case HELP_JAIL:
> > -		return (gettext("\tjail <jailid> <filesystem>\n"));
> > +		return (gettext("\tjail <jailid|jailname> <filesystem>\n"));
>=20
> Please keep the style consistent. As you can see two lines above there
> are spaces around |.
>=20

Sure but both syntax are present in the usage: <filesystem|volume|snapshot>=
 in
fact the only one with space around | is the line above you are showing, al=
l the
rest of the usage is without space, That is why I did it without spaces.

If you tell me it is better with spaces, I'll add space.

regards,
Bapt

--Y9o+fgG4MNl0mnzl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlBbjOMACgkQ8kTtMUmk6EyUTwCeI7gGybplsOsDYFs6a51Ce38X
cdAAnAkoiZqCF/NBYJ+pnuBCbspxHmEP
=uzqg
-----END PGP SIGNATURE-----

--Y9o+fgG4MNl0mnzl--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120920213843.GQ26107>