From owner-freebsd-arch@freebsd.org Mon Sep 28 15:06:12 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CA5BA424E3E for ; Mon, 28 Sep 2020 15:06:12 +0000 (UTC) (envelope-from greg.bal4@gmail.com) Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C0Qnw0R9Zz4TQp; Mon, 28 Sep 2020 15:06:11 +0000 (UTC) (envelope-from greg.bal4@gmail.com) Received: by mail-ej1-x643.google.com with SMTP id p9so9014550ejf.6; Mon, 28 Sep 2020 08:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cs9LikzKre3gmlp1I4QIvxoBRoBnIIJenS+wldQUrcU=; b=YTVL4vejF4wkVfY20ZzmwXBM1VztD0e3Xq5NXOfxKwxX/U6SsKVTNRVjTRhkhCV939 QRsED1753S8ynrnGdEKsXXcFGELdrUO1g72ls4MtbgUj2EYqNNM9myjujLRGWaGkMQ+A C40Nvb1maa5efPZKXDXHAnaQbAszMRFtckwngnNbxLfCv5+hzlx0hMptfOUNkMDpvtXW VDBlphScy00V0en+oa8/fwBYsrJiypA+UeF6ZSO2b9ZyviIds39ZWsVcinNc8p75YKeP frvtCwLSbthl1F1YD0IqeK1Q+dqUxPeTolbL2bxa1y2DFE3ZDPp9GSzOVO0WM2HgYeia xrAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cs9LikzKre3gmlp1I4QIvxoBRoBnIIJenS+wldQUrcU=; b=Bm5fMXHGjp5qdksWv71+jhACAyAHTxah9ZWr9M5HUlC8yBBD0PsbYv0JbVOpX5do8O ppUa9gHsbU+utB3HxcxXqi7OQ9uCVw7GRqGxnNln89s1Nhf2iA19ZRFKbRj6upaw4K7B NgExc8zQpQZeLGSvT/6BxwbIGyOX/GNoxsNMUFfsyFSjDWNkI2I+YNY3YlCoQOn73snm 3TaltaBu1u2jkdE1A5rjEO0XSIGD8SWuLW8biLMI/qpO+m9XE9DxCZU3Sd0eBzuMBx6t /79lnX/28BfgCSJzczofr0+Jclg6K+RPSE4jdQ1OCbLyV5GW+Lyxmgd0LjxoWq//6NU/ DjbQ== X-Gm-Message-State: AOAM530S8hfgWjEPOpcM5zzmqnWMek4zmpFJsQXlu6OU5Tok0ZL+Ppg6 VgncxoiHBFExwh1L8p2qj2vUgya+8wG6r+R4Wj6CrYMwF/E= X-Google-Smtp-Source: ABdhPJywt3Knz8ZKuhbI0BQaVsNcQeTJbPao/b+8k7x7V+gQi4rVTN9LBKDYOn1yx2W2Ccs3A1R2qOgFYD4mPiGH20Y= X-Received: by 2002:a17:907:685:: with SMTP id wn5mr2014276ejb.285.1601305570646; Mon, 28 Sep 2020 08:06:10 -0700 (PDT) MIME-Version: 1.0 References: <20200928045733.GE72348@eureka.lemis.com> In-Reply-To: <20200928045733.GE72348@eureka.lemis.com> From: Greg Balfour Date: Mon, 28 Sep 2020 10:05:59 -0500 Message-ID: Subject: Re: Refactoring calendar(1) (was: svn commit: r365984 - head/usr.bin/calendar/calendars) To: "Greg 'groggy' Lehey" Cc: freebsd-arch@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4C0Qnw0R9Zz4TQp X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=YTVL4vej; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gregbal4@gmail.com designates 2a00:1450:4864:20::643 as permitted sender) smtp.mailfrom=gregbal4@gmail.com X-Spamd-Result: default: False [-3.62 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.982]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::643:from]; NEURAL_HAM_SHORT(-0.63)[-0.634]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-arch]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2020 15:06:12 -0000 On Sun, Sep 27, 2020 at 11:57 PM Greg 'groggy' Lehey wrote: > > On Sunday, 27 September 2020 at 23:25:20 -0500, Greg Balfour wrote: > > On Thu, Sep 24, 2020 at 09:07:08AM +1000, Greg 'groggy' Lehey wrote: > >> > >> While I have your attention, does anybody think that the -a option of > >> calendar(1) is worth keeping? It goes through *all* calendar files on > >> a system and mails them to the owner. It has the interesting side > >> effect (we wouldn't want to call it a bug) that root gets three copies > >> (one each for root, toor and daemon). I can't see anything useful > >> there that a per-user cron job can't do. > > > > I actually use the -a option. But it hasn't fully worked since 10.0-RELEASE. > > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205580 > > Still present in 12.2-BETA2. > > Interesting. > > > I maintain a local set of patches that solves this bug, but it > > requires the installation of the tradcpp port/package so I've never > > shared them, but would if someone wants them. > > You could add them to the bug report; arguably they would point to a > way to fix it without tradcpp. But my real concern is described in > bug 246943, and so far I don't see a clean solution for that. > > Does root have a calendar file on your systems? If so, how do you > handle the multiple emails? Your input on 246943 would be > interesting. I've added my patch to bug 205580. As fas as bug 246943 goes, I've never had a .calendar in root so I've never had to consider this issue. But I would agree with comment #4 in the report. For a fix, I think adding a knob in calendar files per comment #13 is the best solution. However I would not be against removing the -a flag. I would just refactor my use case of calendar(1). I'm tired of keeping my patch up to date so I may just go that route anyway.