From owner-cvs-all@FreeBSD.ORG Sat Jun 14 12:35:10 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B3B8106567A for ; Sat, 14 Jun 2008 12:35:10 +0000 (UTC) (envelope-from saper@system.pl) Received: from system.pl (ns356865.ovh.net [91.121.143.223]) by mx1.freebsd.org (Postfix) with ESMTP id 9D2058FC21 for ; Sat, 14 Jun 2008 12:35:08 +0000 (UTC) (envelope-from saper@system.pl) Received: (qmail 4885 invoked by uid 10); 14 Jun 2008 14:35:09 +0200 Received: from radziecki.saper.info (localhost [127.0.0.1]) by radziecki.saper.info (8.14.2/8.14.2) with ESMTP id m5ECY7w8018470 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Jun 2008 14:34:07 +0200 (CEST) (envelope-from saper@SYSTEM.PL) Message-ID: <4853BABC.2040500@SYSTEM.PL> Date: Sat, 14 Jun 2008 14:34:04 +0200 From: Marcin Cieslak User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8.1.13) Gecko/20080405 SeaMonkey/1.1.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Jeremy Messenger References: <200806132211.m5DMBONf038311@repoman.freebsd.org> <48532AFC.4030004@SYSTEM.PL> In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=B0636ED9; url=http://saper.info/key Content-Type: multipart/signed; micalg=pgp-ripemd160; protocol="application/pgp-signature"; boundary="------------enig3DAFC8D8506AEE984C70A783" Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Edwin Groothuis Subject: Re: cvs commit: ports/net/tn5250j Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 12:35:10 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3DAFC8D8506AEE984C70A783 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: quoted-printable Jeremy Messenger wrote: > On Fri, 13 Jun 2008 21:20:44 -0500, Marcin Cieslak wr= ote: >=20 >> Jeremy Messenger wrote: >>> Do that need to be check careful. I rather to avoid use ${BUILD_DEPEN= DS} >>> and do the copy-n-paste full lines instead. Are zip and ant need to b= e >>> in the runtime dependency? The ${BUILD_DEPENDS} causes USE_*=3Dyes to= be >>> include in the runtime dependency. >> >> No, zip is needed only to unpack the distfile, ant is only needed to >> build the stuff (it's just like "make"). >=20 > # make run-depends-list | grep ant > /usr/ports/devel/apache-ant >=20 That's exactly the reason why RUN_DEPENDS=3D ${BUILD_DEPENDS} is wrong :-= ( Thanks for pointing out. There I would propose another patch: retrieving revision 1.1 diff -u -u -r1.1 Makefile --- Makefile 13 Jun 2008 02:37:00 -0000 1.1 +++ Makefile 14 Jun 2008 12:31:54 -0000 @@ -17,8 +17,13 @@ BUILD_DEPENDS=3D ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \ ${JYTHON_JAR}:${PORTSDIR}/lang/jython \ - ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen -RUN_DEPENDS=3D ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \ + ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \ + ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \ + ${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j +RUN_DEPENDS=3D ${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \ + ${JYTHON_JAR}:${PORTSDIR}/lang/jython \ + ${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \ + ${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \ ${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j USE_ZIP=3D yes --=20 << Marcin Cieslak // saper@system.pl >> --------------enig3DAFC8D8506AEE984C70A783 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQCVAwUBSFO6vz2W2v2wY27ZAQPFqAP/SIP3mMOp+bGD8x9AB6d+lh/3xQ1vZEM/ YRz+ohxL9lJqkCwxz6766SsW487RQxTDYGVNmMbEkKkv6+NTHC5rpb0PXaNiWkU6 XKqqleTykXVJeMehNuSFFPratJqigeYDuvryJAzqQYC9o8aJRvofW0MXyQx5VEPi KAk+J/jS1XY= =3Xtc -----END PGP SIGNATURE----- --------------enig3DAFC8D8506AEE984C70A783--