Date: Fri, 31 May 2002 02:23:10 -0700 From: "Vadim Mikhailov" <mvp@braz.ru> To: "Andrey A. Chernov" <ache@nagual.pp.ru>, <alpha@freebsd.org> Cc: <kris@obsecurity.org>, <gallatin@cs.duke.edu>, <idnopheq@comcast.net>, <marcus@marcuscom.com> Subject: Re: ports/33170: zip -T [zip file] fails with message about missing end signature Message-ID: <000901c20884$c7e84af0$0200000a@mvp> References: <116727983.20020531125229@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Andrey! I agree that I should have checked for fstat() retcode, but: 1) This check does not really matter - zip was broken anyway, and I use that local fsize() function just once. 2) You could have done it yourself, it's just one more line of code. 3) We need working zip _really_ fast before cut-off date for 4.6-R to compile mozilla with prevents compiling gnome. About checking for __FreeBSD_version - this is not kernel code, it's just damn zip. My patch is just an additional sanity check before calling fseek(), it does not really depend on kernel version. So why should we care? P.S. I'm a little bit tired of this. I knew how to get things work 3 months ago, and whoever submitted/reviewed kern/6184 knew it 4 years ago. All I wanted is to help others. Looks like nobody is interested. Vadim Mikhailov. ----- Original Message ----- From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: <mvp@braz.ru> Cc: <kris@obsecurity.org>; <gallatin@cs.duke.edu>; <idnopheq@comcast.net>; <marcus@marcuscom.com> Sent: Friday, May 31, 2002 1:52 AM Subject: Re: ports/33170: zip -T [zip file] fails with message about missing end signature > > begin 666 patch-negativeseek.dat > > 1) This patch is not needed for FreeBSD-current, so all additional > code must be properly ifdef'ed with __FreeBSD_version check. > > 2) Return code of fstat() is not checked, but must be. > > -- > Andrey A. Chernov > http://ache.pp.ru/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?000901c20884$c7e84af0$0200000a>