From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 19 09:10:09 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 63B72106564A for ; Mon, 19 Sep 2011 09:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 51C748FC12 for ; Mon, 19 Sep 2011 09:10:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8J9A99F061456 for ; Mon, 19 Sep 2011 09:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8J9A9JX061455; Mon, 19 Sep 2011 09:10:09 GMT (envelope-from gnats) Date: Mon, 19 Sep 2011 09:10:09 GMT Message-Id: <201109190910.p8J9A9JX061455@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Attila Nagy Cc: Subject: Re: ports/160820: maintainer update: mail/dovecot2 and dovecot2-pigeonhole X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Attila Nagy List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2011 09:10:09 -0000 The following reply was made to PR ports/160820; it has been noted by GNATS. From: Attila Nagy To: Jase Thew Cc: bug-followup@FreeBSD.org Subject: Re: ports/160820: maintainer update: mail/dovecot2 and dovecot2-pigeonhole Date: Mon, 19 Sep 2011 10:43:50 +0200 This is a multi-part message in MIME format. --------------080107040102030007040908 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, OK, thanks. On 09/19/11 10:34, Jase Thew wrote: > Hi, > > The reason for the patch in > dovecot2-pigeonhole/files/patch-doc_Makefile_in hasn't suddenly gone > away with v0.2.4. Without a regenerated version of this patch to apply > to v0.2.4, there will be left-over files : > > === Checking filesystem state > list of extra files and directories in / (not present before this port > was installed but present after it was deinstalled) > 3357455 3 drwxr-xr-x 2 root wheel 4 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve > 3357456 10 -r--r--r-- 1 root wheel 4173 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve/vacation.txt > 3357457 11 -r--r--r-- 1 root wheel 5016 Sep 19 > 08:08 usr/local/share/doc/dovecot/sieve/spamtest-virustest.txt > > Please refer to ports/158173 for an explanation of why this doc patch > is necessary. > > Can you also please keep in mind, just because a patch no longer > applies cleanly, this doesn't mean that the patch (or more > specifically, the issue that it addresses) is no longer relevant. > > I strongly recommend that you test future PR patches with either a > tinderbox or ports-mgmt/porttools e.g., so that you can identify > issues such as this (left-over files) and have the opportunity to fix > them before submitting a PR. > > I've attached a regenerated > dovecot2-pigeonhole/files/patch-doc_Makefile_in so that the port won't > have any left-over files. > > Regards, > > Jase. > > -- > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158173#reply4 --------------080107040102030007040908 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi,

OK, thanks.

On 09/19/11 10:34, Jase Thew wrote:
Hi,

The reason for the patch in dovecot2-pigeonhole/files/patch-doc_Makefile_in hasn't suddenly gone away with v0.2.4. Without a regenerated version of this patch to apply to v0.2.4, there will be left-over files :

=== Checking filesystem state
list of extra files and directories in / (not present before this port was installed but present after it was deinstalled)
3357455        3 drwxr-xr-x    2 root             wheel   4 Sep 19 08:08 usr/local/share/doc/dovecot/sieve
3357456       10 -r--r--r--    1 root             wheel 4173 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/vacation.txt
3357457       11 -r--r--r--    1 root             wheel 5016 Sep 19 08:08 usr/local/share/doc/dovecot/sieve/spamtest-virustest.txt

Please refer to ports/158173 for an explanation of why this doc patch is necessary.

Can you also please keep in mind, just because a patch no longer applies cleanly, this doesn't mean that the patch (or more specifically, the issue that it addresses) is no longer relevant.

I strongly recommend that you test future PR patches with either a tinderbox or ports-mgmt/porttools e.g., so that you can identify issues such as this (left-over files) and have the opportunity to fix them before submitting a PR.

I've attached a regenerated dovecot2-pigeonhole/files/patch-doc_Makefile_in so that the port won't have any left-over files.

Regards,

Jase.

--

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158173#reply4

--------------080107040102030007040908--