From owner-freebsd-questions@FreeBSD.ORG  Mon Jan 14 01:04:13 2013
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: questions@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 91EC56EE
 for <questions@freebsd.org>; Mon, 14 Jan 2013 01:04:13 +0000 (UTC)
 (envelope-from freebsd-questions-local@be-well.ilk.org)
Received: from asbnvacz-mailrelay01.megapath.net
 (asbnvacz-mailrelay01.megapath.net [207.145.128.243])
 by mx1.freebsd.org (Postfix) with ESMTP id 48EF9960
 for <questions@freebsd.org>; Mon, 14 Jan 2013 01:04:13 +0000 (UTC)
Received: from mail6.sea5.speakeasy.net (mail6.sea5.speakeasy.net
 [69.17.117.50])
 by asbnvacz-mailrelay01.megapath.net (Postfix) with ESMTP id AF56DA71084
 for <questions@freebsd.org>; Sun, 13 Jan 2013 20:04:12 -0500 (EST)
Received: (qmail 2939 invoked from network); 14 Jan 2013 01:04:12 -0000
Received: by simscan 1.4.0 ppid: 31862, pid: 16880, t: 0.3554s
 scanners: clamav: 0.88.2/m:52/d:10739
Received: from unknown (HELO be-well.ilk.org) ([66.92.78.145])
 (envelope-sender <freebsd-questions-local@be-well.ilk.org>)
 by mail6.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP
 for <questions@freebsd.org>; 14 Jan 2013 01:04:11 -0000
Received: from lowell-desk.lan (lowell-desk.lan [172.30.250.8])
 by be-well.ilk.org (Postfix) with ESMTP id 2B87833C1D;
 Sun, 13 Jan 2013 20:04:05 -0500 (EST)
Received: by lowell-desk.lan (Postfix, from userid 1147)
 id AC3FE39829; Sun, 13 Jan 2013 20:04:04 -0500 (EST)
From: Lowell Gilbert <freebsd-questions-local@be-well.ilk.org>
To: Adam Vande More <amvandemore@gmail.com>
Subject: Re: sh script problem with capturing return code
References: <50EC9009.3030305@a1poweruser.com>
 <20130108224626.8c2d89cd.freebsd@edvax.de>
 <50EC99F2.3020404@a1poweruser.com> <44d2xevlhb.fsf@lowell-desk.lan>
 <50ED88CF.7060308@a1poweruser.com> <448v82unxb.fsf@lowell-desk.lan>
 <444niqum7n.fsf@lowell-desk.lan> <44zk0it6t5.fsf@lowell-desk.lan>
 <44r4ltu8zp.fsf@lowell-desk.lan>
 <CA+tpaK3xUAz_F+d02Qckkgb+m1bFdBVTMJ7tFp3RJ4z5e6988A@mail.gmail.com>
Date: Sun, 13 Jan 2013 20:04:04 -0500
In-Reply-To: <CA+tpaK3xUAz_F+d02Qckkgb+m1bFdBVTMJ7tFp3RJ4z5e6988A@mail.gmail.com>
 (Adam Vande More's message of "Wed, 9 Jan 2013 21:07:57 -0600")
Message-ID: <44libw8tiz.fsf@lowell-desk.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain
Cc: FreeBSD questions <questions@freebsd.org>
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>, 
 <mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2013 01:04:13 -0000

Adam Vande More <amvandemore@gmail.com> writes:

> On Wed, Jan 9, 2013 at 7:23 PM, Lowell Gilbert <
> freebsd-questions-local@be-well.ilk.org> wrote:
>
>> Lowell Gilbert <freebsd-questions-local@be-well.ilk.org> writes:
>>
>> > I think it's a real bug, and the test cases don't cover "extra" elements
>> > at all. Now I just have to figure out the right fix.
>>
>> I'm pretty sure that the fix is just to set rval on jumping to the
>> "extra" tag in vwalk() in src/usr.sbin/mtree/verify.c.
>>
>> But my hot water heater just exploded, so I may not look at code for a
>> few more days.
>
>
> I think they are importing NetBSD's updated mtree, perhaps already fixed
> there.

It isn't. Which means I probably should submit fixes to multiple places.

Although NetBSD's changes seem fairly minor to me, from a quick look.
The merge should not be difficult, no matter how it's approached.