From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 6 10:30:21 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 367A416A41F for ; Thu, 6 Oct 2005 10:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6453343D4C for ; Thu, 6 Oct 2005 10:30:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j96AUKEm046290 for ; Thu, 6 Oct 2005 10:30:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j96AUK4X046289; Thu, 6 Oct 2005 10:30:20 GMT (envelope-from gnats) Resent-Date: Thu, 6 Oct 2005 10:30:20 GMT Resent-Message-Id: <200510061030.j96AUK4X046289@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stephane Bortzmeyer Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CA58A16A41F for ; Thu, 6 Oct 2005 10:24:54 +0000 (GMT) (envelope-from bortzmeyer@esther.generic-nic.net) Received: from mail.generic-nic.net (eve.generic-nic.net [192.134.7.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4716B43D49 for ; Thu, 6 Oct 2005 10:24:53 +0000 (GMT) (envelope-from bortzmeyer@esther.generic-nic.net) Received: from esther.generic-nic.net (esther.generic-nic.net [192.134.7.248]) by mail.generic-nic.net (Postfix) with ESMTP id 7D9DF22AFA0 for ; Thu, 6 Oct 2005 12:24:52 +0200 (CEST) Received: by esther.generic-nic.net (Postfix, from userid 1000) id 6773464E6; Thu, 6 Oct 2005 12:26:47 +0200 (CEST) Message-Id: <20051006102647.6773464E6@esther.generic-nic.net> Date: Thu, 6 Oct 2005 12:26:47 +0200 (CEST) From: Stephane Bortzmeyer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/86980: The clamav port uses a fixed GID X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stephane Bortzmeyer List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2005 10:30:21 -0000 >Number: 86980 >Category: ports >Synopsis: The clamav port uses a fixed GID >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 06 10:30:19 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Stephane Bortzmeyer >Release: FreeBSD 5.4-RELEASE i386 >Organization: AFNIC >Environment: System: FreeBSD esther.generic-nic.net 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Sun May 8 10:21:06 UTC 2005 root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: The clamav port (/usr/ports/security/clamav) uses a fixed GID (106, hardwired in files/pkg-install.in) without any sensible reason. This prevents me from installing it, since I already have such a group. >How-To-Repeat: If you already have a group of GID 106: esther:ports/security/clamav % sudo make install ===> Installing for clamav-0.87 ===> clamav-0.87 depends on executable: lha - found ===> clamav-0.87 depends on executable: unarj - found ===> clamav-0.87 depends on executable: unrar - found ===> clamav-0.87 depends on executable: zoo - found ===> clamav-0.87 depends on executable: arc - found ===> clamav-0.87 depends on executable: unzip - found ===> clamav-0.87 depends on shared library: gmp.6 - found ===> clamav-0.87 depends on shared library: curl.3 - found pw: gid `106' has already been allocated => Adding group "clamav" failed... *** Error code 1 Stop in /usr/ports/security/clamav. >Fix: No port should use a fixed GID (specially under 100) unless there is a very good reason (and a method to deal with collisions). The following patch seems to cure the problem: --- files/pkg-install.in.ORIG Thu Oct 6 12:24:50 2005 +++ files/pkg-install.in Thu Oct 6 12:25:17 2005 @@ -16,7 +16,7 @@ if [ "$2" = "PRE-INSTALL" ]; then if ! pw groupshow "$CLAMAVGROUP" 2>/dev/null 1>&2; then - if pw groupadd $CLAMAVGROUP -g $GID; then + if pw groupadd $CLAMAVGROUP; then echo "=> Added group \"$CLAMAVGROUP\"." else echo "=> Adding group \"$CLAMAVGROUP\" failed..." There is probably an identical issue with the UID. >Release-Note: >Audit-Trail: >Unformatted: