From owner-svn-src-all@freebsd.org Fri Feb 12 11:27:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5100EAA45FF for ; Fri, 12 Feb 2016 11:27:20 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E4A9C1798 for ; Fri, 12 Feb 2016 11:27:19 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wm0-x232.google.com with SMTP id g62so58363140wme.0 for ; Fri, 12 Feb 2016 03:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=G6hlHGiHoXLRHDp6Lnr8p67aXO6JephlIDnduNG+mgA=; b=H6iEyDyc7KOejYIJTDcnQIQx1T+I8SY/kKSfhsbZ/joyGj8NX8Ox1cA8dBr1uq7XMY 3Z9CMeqVCnx3KXmEwBIHBDjPIaU1//eSexbBpST6lFhnqXpQ5fed9FSh8QXiD7xMYD41 07xfFDMnHQAXmsqPciA4XNIYUSaOpZyGz+YeYEayAk0JcBqDhDDDygeSlDuCfqhDZSys YF8ClCFGWx5uGBSdWi2zu667xf7eDxdhR7EXkGnCIlDiHHP/COoeFqF+DHGATChU/1qy T0MwCGYGD+nUpgllxAuz1A47zCtM7AiI8N1+71SzMc8vsXMC3rkjafS7WgPp+wk9XeSL 050A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=G6hlHGiHoXLRHDp6Lnr8p67aXO6JephlIDnduNG+mgA=; b=iXPRB//5A08vDuyt8+ExROM1qnYTfIyoxfHJv+RibUADidxS5Tavr8uCSHcM3V6gu5 UmHoX5JxhWDa1hGBMWbCgW/fYnv1ss+xHr6wh7dWTWqGEnSTlsaQ2hqIqX6vnIWYNFUK EIYA+Azikmq1ZlcSPFacbqlffoJqd9VoNWZsOXXj2EmaZSzaO7HDnI7YJiQP88qbZ5RN 1GFCMUfneCzZwaiVdBvf4xLu6HNMHoymFg+OcKVyy7llT1N1gGJ2Od+A7IVRRcf3IN2Q Kq5D/FSAVIsIv6Ybltu0qSWoI/WSCadaK9GnuiNtRLijtpMrNn7C5ud3cFKumbJJ0je9 DljA== X-Gm-Message-State: AG10YOSjoHLmQVSXq3Xj7tBcaWKzK2KNkIDSb0sQY9SPvxgToNK/x1S1FsRTAIMawaCY0wWv X-Received: by 10.194.61.73 with SMTP id n9mr1402443wjr.36.1455276438101; Fri, 12 Feb 2016 03:27:18 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id i10sm1939201wmf.14.2016.02.12.03.27.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 12 Feb 2016 03:27:16 -0800 (PST) Subject: Re: svn commit: r295525 - stable/10/sys/dev/ixgbe To: Sean Bruno , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org References: <201602111635.u1BGZGTs031940@repo.freebsd.org> From: Steven Hartland Message-ID: <56BDC194.6070001@multiplay.co.uk> Date: Fri, 12 Feb 2016 11:27:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <201602111635.u1BGZGTs031940@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 11:27:20 -0000 There's a typo here and the unreverted version is still present in head, was this the intention? Clearly the code does limit it to 8, so the old description is more correct, just needs the typo fixing, but I would have expected this to have been corrected in head first and then MFC'ed This was reported to me by Dmitry Luhtionov. Regards Steve On 11/02/2016 16:35, Sean Bruno wrote: > Author: sbruno > Date: Thu Feb 11 16:35:16 2016 > New Revision: 295525 > URL: https://svnweb.freebsd.org/changeset/base/295525 > > Log: > Revert sysctl description change introduced in r295008 to correctly > reflect the maximum number of queues supported (8) by this driver. > > Submitted by: jwd > Reviewed by: erj > Approved by: re (gjb) > Sponsored by: Intel Corporation and Limelight Networks > > Modified: > stable/10/sys/dev/ixgbe/if_ix.c > > Modified: stable/10/sys/dev/ixgbe/if_ix.c > ============================================================================== > --- stable/10/sys/dev/ixgbe/if_ix.c Thu Feb 11 16:16:10 2016 (r295524) > +++ stable/10/sys/dev/ixgbe/if_ix.c Thu Feb 11 16:35:16 2016 (r295525) > @@ -320,7 +320,8 @@ SYSCTL_INT(_hw_ix, OID_AUTO, enable_msix > static int ixgbe_num_queues = 0; > TUNABLE_INT("hw.ix.num_queues", &ixgbe_num_queues); > SYSCTL_INT(_hw_ix, OID_AUTO, num_queues, CTLFLAG_RDTUN, &ixgbe_num_queues, 0, > - "Number of queues to configure, 0 indicates autoconfigure"); > + "Number of queues to configure up to a mximum of 8," > + "0 indicates autoconfigure"); > > /* > ** Number of TX descriptors per ring, >