From owner-cvs-src@FreeBSD.ORG Mon Sep 13 17:33:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BBB816A4D0 for ; Mon, 13 Sep 2004 17:33:35 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA69F43D4C for ; Mon, 13 Sep 2004 17:33:34 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 25139 invoked from network); 13 Sep 2004 17:33:34 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 13 Sep 2004 17:33:33 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8DHXS6m041610; Mon, 13 Sep 2004 13:33:28 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Scott Long Date: Mon, 13 Sep 2004 11:35:47 -0400 User-Agent: KMail/1.6.2 References: <200409111007.i8BA7MeA090701@repoman.freebsd.org> In-Reply-To: <200409111007.i8BA7MeA090701@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409131135.48194.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c src/sys/kern sched_4bsd.c sched_ule.c src/sys/sys proc.h sched.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2004 17:33:35 -0000 On Saturday 11 September 2004 06:07 am, Scott Long wrote: > scottl 2004-09-11 10:07:22 UTC > > FreeBSD src repository > > Modified files: > sys/i386/i386 pmap.c > sys/kern sched_4bsd.c sched_ule.c > sys/sys proc.h sched.h > Log: > Revert the previous round of changes to td_pinned. The scheduler isn't > fully initialed when the pmap layer tries to call sched_pini() early in > the boot and results in an quick panic. Use ke_pinned instead as was > originally done with Tor's patch. > > Approved by: julian Thanks, I think td_pinned belongs in struct thread just as td_critnest. Not all parts of the scheduler purely live in sched_foo.c. Arguably things sleep queues are also part of the scheduler since they deal with queues of threads and manipulating thread state machines, so I think that while some things should be private to sched_foo, not everything has to be completely private. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org