Date: Sat, 25 Nov 2023 11:15:11 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 275329] net-p2p/jigdo: Upgrade to 0.8.2 Message-ID: <bug-275329-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275329 Bug ID: 275329 Summary: net-p2p/jigdo: Upgrade to 0.8.2 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: mc.dhuibh@proton.me Created attachment 246561 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D246561&action= =3Dedit Patch to upgrade net-p2p/jigdo to v0.8.2 As mentioned in PR 266573 the author of net-p2p/jigdo has updated the softw= are to use sha256 instead of MD5. The current version is now 0.8.2 though. I'm submitting the attached patch, which successfully builds in Poudriere with FreeBSD 12.4 and 13.2 jails. I can also test on the just-released v14. I needed to add both docbook-utils as well as sgmlformat dependencies to get the man pages to build. I was unable to get the html versions of the documentation to build using docbook2html, which is expected by the way the author structured the build. I don't know if the problem is with docbook-ut= ils or the source files or another explanation. The porters handbook implies the html documentation is optional, so I modified the makefiles to only build t= he man pages. One of the sed calls used to rename the man page output of docbook2man I co= uld not get to work. (The makefiles don't have comments explaining, but it looks like the sgml to man file conversion by docbook2man produces filenames with locale information that the author's scripts removed.) So I did the file renaming using brename and added a dependency to make sure it' available. I didn't see direction in the porters handbook about preferred renaming utilities, so if using brename is the wrong way to do this, I can try again= a different way. I did need to set MAKE_JOBS_UNSAFE, I think because I couldn't use the auth= or's makefile code to move the man pages out of the temporary directory the auth= or uses to create them, and the line or two I added do it instead didn't like multiple jobs. I wasn't sure how to fix that though. The new distfile I checked using the author's gpg key and signature, which = he provides on his webpage. With the attached patch I removed from the package Makefile the GUI options, because it looks like this depended on Glade2/GTK2 and I guess those are not really in FreeBSD ports anymore? So didn't see how the GUI option could be built any longer from available ports. Portlint complained there was no license field completed, but that's also t= he case with the current port version. The author seems to be using a modified version of GPLv2, so I added the name of the file that contains the license information, but wasn't sure what else to do because the license wasn't strictly GPL. Docbook2man objected to a missing closing paragraph tag in one of the sgml source files used to build the documentation, so I patched that too. The porters handbook says prefer not to manually strip binaries produced wi= th the port, but the current port does that and when I tried removing the post-install call that strips the binary the resulting package had an unstripped binary. I don't know if that was supposed to happen, so I left t= he post-install STRIP_CMD alone. Thank you for considering upgrading this port to 0.8.2! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-275329-7788>