From owner-freebsd-fs@FreeBSD.ORG Sat Mar 26 08:09:22 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BECDA106566C for ; Sat, 26 Mar 2011 08:09:22 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4E95B8FC16 for ; Sat, 26 Mar 2011 08:09:21 +0000 (UTC) Received: by fxm11 with SMTP id 11so2084370fxm.13 for ; Sat, 26 Mar 2011 01:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:x-comment-to :sender:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=h6lVFVYyrVpiaXVEmcJKkkrm1VDzi659ORS0dvcqxTE=; b=X+tWseGdw/oMANxEI9JPsjXpr2WgNWCvDtr1aPteOUbq7jk+7pZ7B8VvnC1iJ3vLra byzV/RF/+Ni9Xl+F+4VONfeMfvFV+DBsxVxDBGlSxSpSd1I/tyuSEHTQIPHWw4RHvLA9 eZpCDHBJp3JdIsd2RtgPwMT/45jgi65TklO/0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=mvw1AJhemux7m4NfW5da1HoE/pDBNRXeJyf6e/OmP3kD48+husoxpqFGB2zijwLKwY r8AEa9X75aiPBoBcxDHvQPg9wOfvItZWr4jLYk8KRFz6udGfQu6Zrl4rezXVBXF7wcqV pWvauA6nke9OIa2x4TJMhva98rKhFVOXJxgfo= Received: by 10.223.20.216 with SMTP id g24mr1909138fab.115.1301126961259; Sat, 26 Mar 2011 01:09:21 -0700 (PDT) Received: from localhost ([95.69.172.154]) by mx.google.com with ESMTPS id 14sm706456fae.47.2011.03.26.01.09.18 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Mar 2011 01:09:19 -0700 (PDT) From: Mikolaj Golub To: giffunip@tutopia.com References: <650638.91967.qm@web113506.mail.gq1.yahoo.com> X-Comment-To: Pedro F. Giffuni Sender: Mikolaj Golub Date: Sat, 26 Mar 2011 10:09:16 +0200 In-Reply-To: <650638.91967.qm@web113506.mail.gq1.yahoo.com> (Pedro F. Giffuni's message of "Fri, 25 Mar 2011 18:01:39 -0700 (PDT)") Message-ID: <86wrjmtiab.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2011 08:09:22 -0000 On Fri, 25 Mar 2011 18:01:39 -0700 (PDT) Pedro F. Giffuni wrote: PFG> --- On Fri, 3/25/11, Kostik Belousov wrote: PFG> .... >> No, I do not want it in our testing framework. I want to >> see a standalone test that demonstrates the issue. >> I think the leak is real, but want to have a way to >> reproduce it before committing. >> >> The diff you pointed out to t_vnops.c does not make much >> sense to me. PFG> I looked a little more in their records and I found this: PFG> _____ PFG> ... PFG> /* rename directory over an empty directory */ PFG> md(pb1, mp, "parent"); PFG> md(pb2, mp, "parent/dir1"); PFG> md(pb3, mp, "parent/dir2"); PFG> RL(rump_sys_mkdir(pb1, 0777)); PFG> RL(rump_sys_mkdir(pb2, 0777)); PFG> RL(rump_sys_mkdir(pb3, 0777)); PFG> RL(rump_sys_rename(pb2, pb3)); PFG> RL(rump_sys_stat(pb1, &sb)); PFG> ATF_CHECK_EQ(sb.st_nlink, 3); PFG> RL(rump_sys_rmdir(pb3)); PFG> if (FSTYPE_TMPFS(tc)) PFG> atf_tc_expect_signal(-1, "PR kern/44288"); PFG> ______ PFG> There's also this that was removed once the PR was fixed: PFG> - if (FSTYPE_MSDOS(tc)) PFG> - atf_tc_skip("test fails in some setups, reason unknown"); PFG> hope that helps. I suppose doing something like this on msdos fs: mkdir parent mkdir parent/1 mv parent/1 parent/2 ls -dl parent In the case of the leak we should see 4 in hard links number field instead of expected 3. But in FreeBSD it looks like msdosfs always reports link count 1: /dev/md1 on /mnt (msdosfs, local) [root@lolek ~]# cd /mnt/ [root@lolek /mnt]# mkdir parent [root@lolek /mnt]# mkdir parent/1 parent/2 parent/3 [root@lolek /mnt]# ls -ld parent drwxr-xr-x 1 root wheel 4096 Mar 26 11:56 parent Tested on 8-STABLE and CURRENT. -- Mikolaj Golub