From owner-freebsd-current Thu Jan 28 21:50:42 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA25641 for freebsd-current-outgoing; Thu, 28 Jan 1999 21:50:42 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA25634 for ; Thu, 28 Jan 1999 21:50:40 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id VAA01443; Thu, 28 Jan 1999 21:43:53 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdFe1440; Fri Jan 29 05:43:44 1999 Date: Thu, 28 Jan 1999 21:43:41 -0800 (PST) From: Julian Elischer To: Greg Lehey cc: current@FreeBSD.ORG Subject: Re: btokup().. patch to STYLE(9) (fwd) In-Reply-To: <19990129155911.Q8473@freebie.lemis.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 29 Jan 1999, Greg Lehey wrote: > On Friday, 29 January 1999 at 16:26:53 +1100, John Birrell wrote: > > I'm sure they might. But they'd be wrong. I do believe that > maintaining a coherent style is a Good Thing. I just dislike the > particular style, but since it doesn't significantly lower my standard > of living, I put up with it :-) I know that there are times when I've been working on code, and that I've added parens to help me (who now understands the code) feel comfortable that I will understand it next time I'm visiting it, and when I've committed it someone rips out the parens with the comment.. "make it KNF". Now if I'm working on some piece of code and feel that it could do with some parens then surely KNF should be flexible enough to allow them.. I don't know how many bugs have ben revealed by adding parens and braces.. I know that one of the first things I do when looking for a bug is add as many as I can in parts of the code that are suspect. It's amazing how often it shows up the problem. KNF is propogating what I consider to be bad practice, and that annoys me. I'm happy to say that often they should be dropped, but to FORCE the dropping of braces etc. with no regard to readbility is too much. julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message