From nobody Sat May 3 08:14:29 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZqLDP4bCPz5twGG; Sat, 03 May 2025 08:14:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZqLDP1yMsz3dWW; Sat, 03 May 2025 08:14:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746260069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mrkyU7hTI1raE0JAcAvCVrL3+1oxOsveFM1ba+PLsD8=; b=JOVCEx7FBxgrvT57Mni09x6wtF/dTFPKRphGFp1MzJULJFcLwe4GXR5PMatr4AIXBKNtIN QaAxSW9BP9hjdVh0OB/5AYhnNMxObZ7/Saq1SnBeRkq0JqXJw5oJMyb0WO/gObOitYkgPj LajVHwXA7jxqIgyr2fk82qWpUjNf5AeM62GCzEzf3vy9ic+Hgrz0l9f6h70GHxnJEAgQDT f5Q3kNJlzZfBmdrzvuRgmw8W8jZ6t5X6rqCxPIbmyt9yLOrFRLpOO2d4/0gTGVZ98oArF9 l03noHj5HrBWW0oG1eC0q1Se1mermGRWwLx5CkgAQTEGXyme/qyJ2uFiQMw6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746260069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mrkyU7hTI1raE0JAcAvCVrL3+1oxOsveFM1ba+PLsD8=; b=VvcGCU+gQ1YVRKkDRNOGqIZ8x6yaTlGVvMnpcEQYddIg38ydQOdjfTK4ZxahouXcY81zT7 YZy4BoyOMS8aX57zUkKDXrwVlhcjqtdCGjRR7ryv7cYA8DJlHwqfpyErAH3TSWEZplIJ2+ GiBpwgSjcNJR2FFijsKW/0grJ8gPfhIb4wTSxyRfw0zOJiwbAcv5RIiCSKZXeWndrxHfp9 WiADfPane7It7lnL+pXEc8dbplBaTy66Bb84BRH8P0CZ61Y8JiPay9t1VZ+sqAUA9Iqygp RcwwClwMXJS9R8KMH2TVfw1wuMpTJ1hD3IV2Wmdsl0GJrBjxv7/7CE1lGuNrLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746260069; a=rsa-sha256; cv=none; b=t/0vlzHbK+szcoZb6peI3v+yVoVsrHF0NqP77bA3lvkTgVcUxPfpF135uOMW0jXtPtjMWp sigw52ljpciqggWnw5zufeXRY9FyW64rtXyiZDokkrdY7CFyaZW55DNbnnx+Tsu6jrGh2a J1Jo7Bn/+v4Ujplk4NzjkmtTtiiUSfc17H7GbtTsEMqfGkBX8IW/KsjGL2rJ8USNuFZAO3 9bOrNUkuZrJYD7IEKTxharTDoBWOqu54uSiMJ3AcIddYBdCg+C/SDUOVkYtUeS5qBWPvCx cLvpAmKxmzqTBwoZLNaYWRfmzRdBFU9ksG717tbMIxg1F1MEQlCFau+iYP5OVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZqLDP1QwyzbDM; Sat, 03 May 2025 08:14:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5438ETKD053399; Sat, 3 May 2025 08:14:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5438EThH053396; Sat, 3 May 2025 08:14:29 GMT (envelope-from git) Date: Sat, 3 May 2025 08:14:29 GMT Message-Id: <202505030814.5438EThH053396@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 4f642f569b47 - main - pfctl: match broadcast address behaviour to the kernel List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4f642f569b47692a53ce142a6b64c506122b0c22 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=4f642f569b47692a53ce142a6b64c506122b0c22 commit 4f642f569b47692a53ce142a6b64c506122b0c22 Author: Kristof Provost AuthorDate: 2025-05-02 12:26:37 +0000 Commit: Kristof Provost CommitDate: 2025-05-03 08:13:53 +0000 pfctl: match broadcast address behaviour to the kernel When using a /32 IPv4 interface address, pfctl(8) reports a 0.0.0.0 as broadcast address. The kernel does not consider this a broadcast address and ifconfig(8) has a check to exclude it. Use the same check in pfctl(8). Found by regress/sbin/pfctl pfi2; OK mikeb@ Obtained from: OpenBSD, bluhm , cf181e999d Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/pfctl_parser.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sbin/pfctl/pfctl_parser.c b/sbin/pfctl/pfctl_parser.c index 8a64578b136d..d814b5f200e1 100644 --- a/sbin/pfctl/pfctl_parser.c +++ b/sbin/pfctl/pfctl_parser.c @@ -1715,6 +1715,8 @@ ifa_lookup(char *ifa_name, int flags) if ((flags & PFI_AFLAG_BROADCAST) && !(p->ifa_flags & IFF_BROADCAST)) continue; + if ((flags & PFI_AFLAG_BROADCAST) && p->bcast.v4.s_addr == 0) + continue; if ((flags & PFI_AFLAG_PEER) && !(p->ifa_flags & IFF_POINTOPOINT)) continue;