From owner-cvs-all Mon Dec 17 1:21:31 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 0CE0C37B419; Mon, 17 Dec 2001 01:21:13 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBH9Kc155539; Mon, 17 Dec 2001 11:20:38 +0200 (EET) (envelope-from ru) Date: Mon, 17 Dec 2001 11:20:38 +0200 From: Ruslan Ermilov To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011217112037.B47617@sunbay.com> References: <20011214204055.I16945@sunbay.com> <200112141930.fBEJUJU06523@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112141930.fBEJUJU06523@grimreaper.grondar.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 07:30:19PM +0000, Mark Murray wrote: > > I was mostly joking actually, didn't expect that people REALLY > > do this. Mark, may I know where this has been discussed, as > > the only one I recall is that not prototyping main() is OK, > > as its prototype is internally known to almost every compiler. > > This was not discussed per se. I just turned on WARNS=2 and fixed the > warnings. If the compiler whined about main(), then I fixed that too. > Perhaps you did it at the times our compiler was broken? See how backing out such a change now doesn't break anything: Index: chflags.c =================================================================== RCS file: /home/ncvs/src/usr.bin/chflags/chflags.c,v retrieving revision 1.13 diff -u -p -r1.13 chflags.c --- chflags.c 2001/12/10 21:13:03 1.13 +++ chflags.c 2001/12/17 09:20:53 @@ -57,7 +57,6 @@ __FBSDID("$FreeBSD: src/usr.bin/chflags/ #include #include -int main __P((int, char *[])); void usage __P((void)); int -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message