From owner-svn-src-head@freebsd.org Sun Jun 17 01:23:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5AD61005995 for ; Sun, 17 Jun 2018 01:23:34 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 858467739F for ; Sun, 17 Jun 2018 01:23:34 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com [209.85.213.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id 4E52E25BCE for ; Sun, 17 Jun 2018 01:23:34 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yb0-f175.google.com with SMTP id a16-v6so1969334ybm.2 for ; Sat, 16 Jun 2018 18:23:34 -0700 (PDT) X-Gm-Message-State: APt69E0APcvAIgPuhDgko4MJOt5y6q7yFKL+NncvHiDk6ulJZQ6kznEK FMIIDBnT3eREoOnvMaS9WAgHy+wWqrmgacc3wvIBHg== X-Google-Smtp-Source: ADUXVKIkXneen5zM2u7GVbkbIzK6SG7HBgG6N0I026AszxLnvzF0PUnP0Oi6NyAaFmTmz/T2nGkP8HhysRITsZWVdpM= X-Received: by 2002:a25:7a01:: with SMTP id v1-v6mr2414758ybc.87.1529198613805; Sat, 16 Jun 2018 18:23:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Sat, 16 Jun 2018 18:23:03 -0700 (PDT) In-Reply-To: <201806170110.w5H1AWqE057910@pdx.rh.CN85.dnsmgr.net> References: <201806162350.w5GNoZld081724@repo.freebsd.org> <201806170110.w5H1AWqE057910@pdx.rh.CN85.dnsmgr.net> From: Eitan Adler Date: Sat, 16 Jun 2018 18:23:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335270 - head/lib/liby To: "Rodney W. Grimes" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 01:23:35 -0000 On 16 June 2018 at 18:10, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: eadler >> Date: Sat Jun 16 23:50:34 2018 >> New Revision: 335270 >> URL: https://svnweb.freebsd.org/changeset/base/335270 >> >> Log: >> liby: build with WARNS=6 >> >> Tested with amd64, arm64, i386, mips >> >> Added: >> head/lib/liby/yyerror.h (contents, props changed) >> Modified: >> head/lib/liby/Makefile >> head/lib/liby/main.c >> head/lib/liby/yyerror.c >> >> Modified: head/lib/liby/Makefile >> ============================================================================== >> --- head/lib/liby/Makefile Sat Jun 16 23:49:22 2018 (r335269) >> +++ head/lib/liby/Makefile Sat Jun 16 23:50:34 2018 (r335270) >> @@ -5,6 +5,4 @@ LIB= y >> SRCS= main.c yyerror.c >> NO_PIC= >> >> -WARNS?= 1 >> - >> .include >> >> Modified: head/lib/liby/main.c >> ============================================================================== >> --- head/lib/liby/main.c Sat Jun 16 23:49:22 2018 (r335269) >> +++ head/lib/liby/main.c Sat Jun 16 23:50:34 2018 (r335270) >> @@ -32,16 +32,17 @@ >> #include >> __FBSDID("$FreeBSD$"); >> >> -#ifndef lint >> +#if defined(LIBC_SCCS) && !defined(lint) >> static char sccsid[] = "@(#)main.c 8.1 (Berkeley) 6/4/93"; >> -#endif /* not lint */ >> +#endif /* LIBC_SCCS and not lint */ >> >> #include >> >> -int yyparse(void); >> +#include "yyerror.h" >> >> int >> main(void) >> { >> + >> exit(yyparse()); >> } >> >> Modified: head/lib/liby/yyerror.c >> ============================================================================== >> --- head/lib/liby/yyerror.c Sat Jun 16 23:49:22 2018 (r335269) >> +++ head/lib/liby/yyerror.c Sat Jun 16 23:50:34 2018 (r335270) >> @@ -32,16 +32,18 @@ >> #include >> __FBSDID("$FreeBSD$"); >> >> -#ifndef lint >> +#if defined(LIBC_SCCS) && !defined(lint) >> static char sccsid[] = "@(#)yyerror.c 8.1 (Berkeley) 6/4/93"; >> -#endif /* not lint */ >> +#endif /* LIBC_SCCS and not lint */ >> >> #include >> >> +#include "yyerror.h" >> + >> int >> -yyerror(msg) >> -char *msg; >> +yyerror(const char *msg) >> { >> - (void)fprintf(stderr, "%s\n", msg); >> + >> + fprintf(stderr, "%s\n", msg); >> return(0); >> } >> >> Added: head/lib/liby/yyerror.h >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/lib/liby/yyerror.h Sat Jun 16 23:50:34 2018 (r335270) >> @@ -0,0 +1,36 @@ > > Where did this file come from???? I added a header file instead of keeping the prototypes in the .c files. Is something wrong with that? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams