From owner-svn-src-head@freebsd.org Sat Jan 13 08:19:16 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3CD5EE7CB54; Sat, 13 Jan 2018 08:19:16 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E0F4C7B152; Sat, 13 Jan 2018 08:19:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id aH1ueuiePS7BpaH1vexi26; Sat, 13 Jan 2018 01:19:09 -0700 X-Authority-Analysis: v=2.2 cv=NKylwwyg c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=RgaUWeydRksA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=VSQ6hZaGqi40Q9fsQmUA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 95E0D3A7; Sat, 13 Jan 2018 00:19:06 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w0D8J6f7006350; Sat, 13 Jan 2018 00:19:06 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w0D8J6gn006347; Sat, 13 Jan 2018 00:19:06 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201801130819.w0D8J6gn006347@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327912 - head/sys/contrib/ipfilter/netinet In-Reply-To: Message from Cy Schubert of "Sat, 13 Jan 2018 08:16:10 +0000." <201801130816.w0D8GAfG024087@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 13 Jan 2018 00:19:06 -0800 X-CMAE-Envelope: MS4wfCXfxTudW2b2Oj2pY5fCGx6L7qRUcU0H8ZqFAVNvi8E4JaJI1LW6qk0p30IK6UM4OYDb2w1w0vXV8vLt2fqBdZwcHTHuJRtkp3LmmG886KxIOTYqQ7cz WPHvFH73o91R6amuzyftACvd8+lAJQx/RnuGldXJv9ppg+wCVGlx2k21o6ZC04MxMNoZlFxbRFAzrRVZBAhViW+AbVdzEYW3dVhsGgyHQ4LIK7ehBCZBE7DV 14Q2sF6iAk3rwApDRHC2uNAgaiOTJn7CvViyJBQ6j6U5jMwdWD5G0qSNBpReorVh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 08:19:16 -0000 In message <201801130816.w0D8GAfG024087@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Sat Jan 13 08:16:10 2018 > New Revision: 327912 > URL: https://svnweb.freebsd.org/changeset/base/327912 > > Log: > Though this block of code is not used by FreeBSD, correct a call to > sprintf() with a macro call to SNPRINTF similar to other calls to > SNPRINTF within this same block. > > MFC after: 1 week > > Modified: > head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > > Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c > ============================================================================= > = > --- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Sat Jan 13 04:53:04 201 > 8 (r327911) > +++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c Sat Jan 13 08:16:10 201 > 8 (r327912) > @@ -2136,7 +2136,7 @@ ipf_p_ftp_eprt6(softf, fin, ip, nat, ftp, dlen) > SNPRINTF(s, left, "%x:%x", a >> 16, a & 0xffff); > left -= strlen(s); > s += strlen(s); > - sprintf(s, "|%d|\r\n", port); > + SNPRINTF(s, left, "|%d|\r\n", port); > #else > (void) sprintf(s, "EPRT %c2%c", delim, delim); > s += strlen(s); Lest anyone fret, sprintf --> snprintf for ipfilter is being worked on and is currently stashed in one of my working directories. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.