From nobody Thu Jan 18 17:35:25 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TG8z60lfgz56YlG for ; Thu, 18 Jan 2024 17:35:30 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TG8z54Cysz478Y for ; Thu, 18 Jan 2024 17:35:29 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-3606ad581a5so57834615ab.1 for ; Thu, 18 Jan 2024 09:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1705599327; x=1706204127; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oEzO5poaepMlkTiGq1a3KImHKuNSnnbFRaqdxXiZOQ4=; b=UgLsNHP0StPFjOc52qUc+r501WuAbgaSU9dcGUhTarJa1rzKwTuuv1HMRTB0XMLnOL R6vpnUIR6PAXnDWjzt182cvHYZsDIdO27ku29fsDnQMZJ1Z5CTh6hkLD4vsLky1VtUIF +mGAcI8AM4IcpvmvpKLJbiSrvKzKVhsdFzURJuXhMcFYM9lQzwKg/at8pkHjzo2XhamT 9CU90/KlKN1vClLmIBHquGIhCfBShOH0Sdt5XIusa5voC3tSKLKY9EvBJq+wOiGjDAP1 qx6BdlAhQ/bJC/YMyUotpdcW3kBkbZGEtXrS4o6pbl9K86eHqCTIif6SlhK82PEMp8RP EeqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705599327; x=1706204127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oEzO5poaepMlkTiGq1a3KImHKuNSnnbFRaqdxXiZOQ4=; b=BS9P0n7IzZOMlhGxf12ev8pr7lzTWlSqTbgAOydPV32y8XUnHQgdoj4HNycUtJa2hT aBxlcLvd1hUnzQdKOFYec3AgP/R6+j/G9X11/YcOmFfyYyCd9hCwi3eaj99lSW7RWuzO qxWXFZvpRteDY4sD5glV0yv6a8b6c56tUcqQq+BbZfH3MTCRlc3Fk49J9vmNqhGwzGD1 2EVwTJ88krA6/9WAQu9496t5uu8rs7DBkocasB4ieDIPfMouP+lZBK2Jekc26x30Tv65 CT5PYCXophWIGCPbfpivH5DkHj9R9ne0vy1HPAuFsaI47XsPqHMqtQN+CGtoVb5201jl Iz4Q== X-Gm-Message-State: AOJu0YwZBxaq+3g4HXyF+OnDGCBsRqwbiXvZcbyN0qo9eR+BKlgSzELD UBTWht/RqdaSq1QrHkKG1EhQa+BL+OcME8bWdPao82dTs3ZydJD2S51Xl4uXBqE= X-Google-Smtp-Source: AGHT+IGDt22LbJOFz+9bHFN5jhcpIQs7YqOeLD7yXoZ07OVDhGiZmagx+jIQQxLoA0TWvbAlf3XI5w== X-Received: by 2002:a92:de04:0:b0:35f:a46f:f40a with SMTP id x4-20020a92de04000000b0035fa46ff40amr1392482ilm.11.1705599326780; Thu, 18 Jan 2024 09:35:26 -0800 (PST) Received: from mutt-hbsd (174-24-119-231.clsp.qwest.net. [174.24.119.231]) by smtp.gmail.com with ESMTPSA id g15-20020a056e021e0f00b003606b6d1070sm4636909ila.22.2024.01.18.09.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 09:35:25 -0800 (PST) Date: Thu, 18 Jan 2024 17:35:25 +0000 From: Shawn Webb To: Jessica Clarke Cc: Cy Schubert , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 0990136ed175 - main - kerberos5: Mitigate the possibility of using an old libcrypto Message-ID: X-Operating-System: FreeBSD mutt-hbsd 15.0-CURRENT-HBSD FreeBSD 15.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202401181523.40IFNvXI077592@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t4jbi7nbtzycxckb" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4TG8z54Cysz478Y X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --t4jbi7nbtzycxckb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 18, 2024 at 05:29:47PM +0000, Jessica Clarke wrote: > On 18 Jan 2024, at 15:23, Cy Schubert wrote: > >=20 > > The branch main has been updated by cy: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0990136ed1753ac7837206f9= c5f4b83ccff6c405 > >=20 > > commit 0990136ed1753ac7837206f9c5f4b83ccff6c405 > > Author: Cy Schubert > > AuthorDate: 2024-01-18 08:22:20 +0000 > > Commit: Cy Schubert > > CommitDate: 2024-01-18 15:12:14 +0000 > >=20 > > kerberos5: Mitigate the possibility of using an old libcrypto > >=20 > > By using the full library name (libcrypto.so.30) we avoid the exposu= re > > of using an old, possibly vulnerable, library. > >=20 > > Reported by: jrtc27 > > MFC after: 3 days > > X-MFC with: 476d63e091c2 > > Fixes: 476d63e091c2 > > --- > > kerberos5/lib/libroken/fbsd_ossl_provider_load.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/kerberos5/lib/libroken/fbsd_ossl_provider_load.c b/kerbero= s5/lib/libroken/fbsd_ossl_provider_load.c > > index 497b32124f96..2328041bc166 100644 > > --- a/kerberos5/lib/libroken/fbsd_ossl_provider_load.c > > +++ b/kerberos5/lib/libroken/fbsd_ossl_provider_load.c > > @@ -5,6 +5,7 @@ > > #include > >=20 > > #if defined(OPENSSL_VERSION_MAJOR) && (OPENSSL_VERSION_MAJOR >=3D 3) > > +#define CRYPTO_LIBRARY "/lib/libcrypto.so.30" >=20 > This still assumes the native ABI is in use, i.e. doesn=E2=80=99t account= for > libcompat. Can we please just drop the directory, or if it=E2=80=99s real= ly > needed for some reason at least handle the libcompat case? Using relative paths might carry a potential security risk if the LD_LIBRARY_PATH environment variable is set to an attacker-controlled directory. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --t4jbi7nbtzycxckb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmWpYVAACgkQ/y5nonf4 4fqryA/9F2cLPzaDGGQ19AbZImSAFplCWJkidv9k+QWZLX9lriXdrdz3qqg+Yu6X bxbETNHo0PjtAZd2hJHp+NdHR497+R+1t0KqmGvRvq0PSuXR/ze68XUjrUS3RfUJ 8fMBOLbdkyXNEeFw5YkjDIGAmhAaCqBEk60dFa8DFfEygbfEZXaws1L4tPsW86B0 sfiPdH57OBEzaiSraK9i+2v9gOPmd5xEuYQ/FK1+xeQ9g2IykibjrO8CfM8J3//4 MoLkqQ+fnaUyaufBg0cEekO0yQhtgfqMrYuB6DjD1NpwWRpKuDnkynflbmrgO7hg SleqZc01cJ1Fa7fCqO+Ds+4l/xVKJ781M7PWbowUtkJQmeUnNVJ4boDPfdIY6v0x GRLgZin1AeWCDRIoV2vR0JqTLf+AVaeeD7iFQnZVR9riWRiHrBWZ0tLoqf1Wk3Sb 4MzEXp/EVhI+aKQ2Cshl1tmNwTncbJ8mR05tjIu5FRSnmJd9rMO/du0ADnGzPDAT 9jB5aw1ht8yIYVay4KWgOt/O4sAVtI6eq8gZOvA6ITP7Z/Htnh3RDC2EhvBdtM90 djUFwwqboMqLDPWw51yO2poicmr88E/kFdt0z4MPoHY1lBipyCGqJ2Gg3ZdTdeqo gnnfAUxaVwrHF3sk/rwpsQtjtI1hnV/S3/RqgVvU2eQOhg+/BK8= =oMkh -----END PGP SIGNATURE----- --t4jbi7nbtzycxckb--