Date: Wed, 9 Mar 2005 17:15:16 -0500 From: Jung-uk Kim <jkim@niksun.com> To: freebsd-amd64@freebsd.org Cc: ia64@freebsd.org Subject: Re: [PATCH] More stackgap removal Message-ID: <200503091715.16990.jkim@niksun.com> In-Reply-To: <200503091031.46073.jhb@FreeBSD.org> References: <200503021643.05580.jhb@FreeBSD.org> <200503091031.46073.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_0V3LC0/VSKdMmMn Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 09 March 2005 10:31 am, John Baldwin wrote: > On Wednesday 02 March 2005 04:43 pm, John Baldwin wrote: > > I've fixed up a few more syscalls to have kern_foo versions so > > that ABI wrappers for them can stop using the stackgap. In this > > patch, I've added kern_settimeofday() for ibcs2 and freebsd32, > > kern_adjtime() for freebsd32, and kern_sched_rr_get_interval() > > for Linux/i386 on amd64 (note that this means that COMPAT_LINUX32 > > now requires POSIX_PRIORITY_SCHEDULING). I've also added > > kern_readv() and kern_writev() for OSF/1, Linux/i386 on amd64, > > and freebsd32. For these functions I added a per-ABI version of > > copyinuio() to build a uio structure from the iovec array in > > userland. Testing and feedback of both native and compat binaries > > greatly appreciated. > > > > http://www.FreeBSD.org/~jhb/patches/abi.patch > > Is anyone willing to test this? The attachment corrects two obvious typos in freebsd32_misc.c. With this, freebsd32 works fine on amd64. Thanks, Jung-uk Kim --Boundary-00=_0V3LC0/VSKdMmMn Content-Type: text/x-diff; charset="iso-8859-1"; name="freebsd32_misc.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="freebsd32_misc.diff" --- src/sys/compat/freebsd32/freebsd32_misc.c Wed Mar 9 17:11:35 2005 +++ src/sys/compat/freebsd32/freebsd32_misc.c Wed Mar 9 16:57:00 2005 @@ -747,7 +747,7 @@ error = freebsd32_copyinuio(uap->iovp, uap->iovcnt, &auio); if (error) return (error); - error = kern_readv(td, uap->fd, auio); + error = kern_writev(td, uap->fd, auio); free(auio, M_IOV); return (error); } @@ -777,7 +777,7 @@ tzp = &tz; } else tzp = NULL; - return (kern_settimeofday(td, tvp, tzp); + return (kern_settimeofday(td, tvp, tzp)); } int --Boundary-00=_0V3LC0/VSKdMmMn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503091715.16990.jkim>