From owner-svn-src-all@freebsd.org Thu Jul 19 19:59:58 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D2D01047C91 for ; Thu, 19 Jul 2018 19:59:58 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 13ED7777CC for ; Thu, 19 Jul 2018 19:59:57 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 4b056150-8b8e-11e8-93fa-f3ebd9db2b94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 4b056150-8b8e-11e8-93fa-f3ebd9db2b94; Thu, 19 Jul 2018 19:59:50 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6JJxnIm003706; Thu, 19 Jul 2018 13:59:49 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532030389.1344.9.camel@freebsd.org> Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 From: Ian Lepore To: Alexey Dokuchaev , Michael Tuexen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 19 Jul 2018 13:59:49 -0600 In-Reply-To: <20180719195302.GA26853@FreeBSD.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> <20180719195302.GA26853@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 19:59:58 -0000 On Thu, 2018-07-19 at 19:53 +0000, Alexey Dokuchaev wrote: > > +++ head/sys/netinet/sctp_asconf.c    Thu Jul 19 19:33:42 2018        (r336503) > >  static struct mbuf * > > -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t *error_tlv, > > +sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t * error_tlv, > > This looks strange now.  In C, asterisk is usually placed by the variable. "usually" may be true of freebsd, but most places I've worked consider the * (and & in c++) to be more associated with the type being declared than with the variable name, thus they get snugged up against the type info, not the var name. Putting the * or & with the var name leads to particularly bad constructs such as   int a, *b; which, for maximal clarity, should be:   int  a;   int* b; -- Ian