Date: Tue, 13 Jun 2017 15:04:58 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jov <amutu@amutu.com> Cc: FreeBSD Ports Mailing List <ports@freebsd.org> Subject: Re: problem about port need /proc to build Message-ID: <20170613120458.GW2088@kib.kiev.ua> In-Reply-To: <CADyrUxPyFRpstE1ZNvBnGgEHMPN=cffuEgNt4vryWy0kOi-3NA@mail.gmail.com> References: <CADyrUxPyFRpstE1ZNvBnGgEHMPN=cffuEgNt4vryWy0kOi-3NA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 13, 2017 at 06:57:40PM +0800, Jov wrote: > Hi ports hackers, > > I am porting tensorflow to FreeBSD, It uses bazel to manage the > dependencies and do the build.The port work now is mostly done (see: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219609,I have local patch > to fix the network need for do-configure) except one problem which I am not > sure. So I write this mail to ask. > > The problem is bazel use /proc to locate its binary when start, > see: > https://github.com/bazelbuild/bazel/blob/255953740813414433eceedc99c2bef3c3f6e307/src/main/cpp/blaze_util_freebsd.cc > : > string GetSelfPath() { > char buffer[PATH_MAX] = {}; > ssize_t bytes = readlink("/proc/curproc/file", buffer, sizeof(buffer)); > if (bytes == sizeof(buffer)) { > // symlink contents truncated > bytes = -1; > errno = ENAMETOOLONG; > } > I am not sure this is acceptable for FreeBSD ports.I now set USE_PROCFS=yes > for poudriere and it can pass the testport. > > If port needs /proc is not acceptable, I will patch devel/bazel to use > sysctl get its binary path. It is not a question about being acceptable or not to use /proc, but about user convenience. FreeBSD does not automatically configure procfs mount and base utilities function without procfs. As result, users typically do not need it. If your port adds dependency on procfs, then it also adds requirements on the machine configuration and some inconvenience to its users. Some programs cannot function without procfs, e.g. jvm. But if it can be trivially avoided, it is better to avoid.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170613120458.GW2088>