From owner-freebsd-standards@FreeBSD.ORG  Wed Jun  8 10:53:26 2005
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
X-Original-To: standards@freebsd.org
Delivered-To: freebsd-standards@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8F69A16A41C
	for <standards@freebsd.org>; Wed,  8 Jun 2005 10:53:26 +0000 (GMT)
	(envelope-from mike@reifenberger.com)
Received: from mailout03.sul.t-online.com (mailout03.sul.t-online.com
	[194.25.134.81])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0E9F743D48
	for <standards@freebsd.org>; Wed,  8 Jun 2005 10:53:25 +0000 (GMT)
	(envelope-from mike@reifenberger.com)
Received: from fwd23.aul.t-online.de by mailout03.sul.t-online.com with smtp 
	id 1DfyBY-0001Xo-03; Wed, 08 Jun 2005 12:53:24 +0200
Received: from fw.reifenberger.com
	(rXRICwZHYergJi3oRnEYROjEFzCncmcyg+RVZF-KVP4EHnMeBh0nUk@[84.152.95.217])
	by fwd23.sul.t-online.de
	with esmtp id 1DfyBH-0ZHU3c0; Wed, 8 Jun 2005 12:53:07 +0200
Received: from localhost (mike@localhost)
	by fw.reifenberger.com (8.13.3/8.13.3/Submit) with ESMTP id
	j58AqgXR030627; Wed, 8 Jun 2005 12:52:42 +0200 (CEST)
	(envelope-from mike@reifenberger.com)
X-Authentication-Warning: fw.reifenberger.com: mike owned process doing -bs
Date: Wed, 8 Jun 2005 12:52:42 +0200 (CEST)
From: Michael Reifenberger <mike@Reifenberger.com>
To: Stefan Farfeleder <stefan@fafoe.narf.at>
In-Reply-To: <20050608103045.GC16848@wombat.fafoe.narf.at>
Message-ID: <20050608124306.X30581@fw.reifenberger.com>
References: <20050608094851.D29843@fw.reifenberger.com>
	<20050608103045.GC16848@wombat.fafoe.narf.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-ID: rXRICwZHYergJi3oRnEYROjEFzCncmcyg+RVZF-KVP4EHnMeBh0nUk@t-dialin.net
X-TOI-MSGID: 3d5fa302-2f53-4a48-b705-8dc12b62b6f9
Cc: standards@freebsd.org
Subject: Re: libstand functions not ansi-c compiliant
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2005 10:53:26 -0000

On Wed, 8 Jun 2005, Stefan Farfeleder wrote:
...
>
> libstand isn't intended to be a standards-compliant C library.  I'm
> afraid I don't see the advantages of your proposed changes.
>

IMHO this would violate POLA.
If the functions are called like standard, they should complay to the standard.

The advantage would be (thats how I got to this issue at all) that
you don't get compiling errors when including <stdio.h> too.
(I had to do this to get the definition of FILE for the work
on upgrading sys/boot/ficl to ficl4)

>> -void
>> +int
>>  vprintf(const char *fmt, va_list ap)
>>  {
>> +	int retval;
>>
>>  	kvprintf(fmt, putchar, NULL, 10, ap);
>
> retval = kvprintf(fmt, putchar, NULL, 10, ap);
>
>> +	return(retval);
>>  }
>
>> @@ -369,7 +369,7 @@
>>   */
>>  extern int		getchar(void);
>>  extern int		ischar(void);
>> -extern void		putchar(int);
>> +extern int		putchar(int);
>
> You can't just change the return type in the header without changing all
> definitions of putchar().
>

It seems that putchar is not implemented in libstand.
Do you know where?

Bye/2
---
Michael Reifenberger, Business Development Manager SAP-Basis, Plaut Consulting
Comp: Michael.Reifenberger@plaut.de | Priv: Michael@Reifenberger.com
       http://www.plaut.de           |       http://www.Reifenberger.com