From owner-freebsd-current Thu Jan 28 21:52:51 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA25818 for freebsd-current-outgoing; Thu, 28 Jan 1999 21:52:51 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA25812 for ; Thu, 28 Jan 1999 21:52:47 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id QAA29572; Fri, 29 Jan 1999 16:22:44 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.2/8.9.0) id QAA16089; Fri, 29 Jan 1999 16:22:44 +1030 (CST) Date: Fri, 29 Jan 1999 16:22:44 +1030 From: Greg Lehey To: Julian Elischer Cc: current@FreeBSD.ORG Subject: Re: btokup().. patch to STYLE(9) (fwd) Message-ID: <19990129162243.V8473@freebie.lemis.com> References: <19990129155911.Q8473@freebie.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: ; from Julian Elischer on Thu, Jan 28, 1999 at 09:43:41PM -0800 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thursday, 28 January 1999 at 21:43:41 -0800, Julian Elischer wrote: > > > On Fri, 29 Jan 1999, Greg Lehey wrote: > >> On Friday, 29 January 1999 at 16:26:53 +1100, John Birrell wrote: >> >> I'm sure they might. But they'd be wrong. I do believe that >> maintaining a coherent style is a Good Thing. I just dislike the >> particular style, but since it doesn't significantly lower my standard >> of living, I put up with it :-) > > I know that there are times when I've been working on code, and that I've > added parens to help me (who now understands the code) feel comfortable > that I will understand it next time I'm visiting it, and when I've > committed it someone rips out the parens with the comment.. "make it > KNF". > > Now if I'm working on some piece of code and feel that it could do with > some parens then surely KNF should be flexible enough to allow them.. > > I don't know how many bugs have ben revealed by adding parens and braces.. > I know that one of the first things I do when looking for a bug is add as > many as I can in parts of the code that are suspect. > > It's amazing how often it shows up the problem. > > KNF is propogating what I consider to be bad practice, and that annoys me. > I'm happy to say that often they should be dropped, but to FORCE the > dropping of braces etc. with no regard to readbility is too much. Don't get me wrong. I'm not disagreeing with you. I'm just saying I don't think it's worth fighting for. If you really want to fight, fight for a complete reform, so that the code looks like the way I prefer :-) Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message