From owner-svn-ports-all@freebsd.org Wed May 22 07:16:09 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C12715A2E08; Wed, 22 May 2019 07:16:09 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB1676FAB2; Wed, 22 May 2019 07:16:08 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf1-x436.google.com with SMTP id s11so819274pfm.12; Wed, 22 May 2019 00:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d45QEr0MKvTweQWjoIK2B8KCF5kYy+7z2mLtcEsOrQU=; b=FX58xOvvoxrfXB2TB9gErtfaRKNSfEQgd4uoNN6yt79dkkMoHVIy42k4OlfKtSVYbv yGtSaGMJa9lHzUn1niJgYomTj6sCSWvzj4IPAG7q3Q1vHNYjXLY0nypV8BE6zFambWtO cyW+Wk69ja3/iTf0Nj2RtYkM1QToMDClv116t94ZqOcZ0wQJN16dAzgcA1uW6Pj1Bgj4 8RPdVnxvz7FyBacUDcWwtI7sqHecAoBN4UT+9GACjf3VIKtU9Xq+8yMBM3J2cUFrSQkf 8CNE3f+am1cC2+bwx9+f8GJLRpr67B4b7oVnx7onUZlO6fPRmlopSd9VKamn+Pee0YMv VpCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d45QEr0MKvTweQWjoIK2B8KCF5kYy+7z2mLtcEsOrQU=; b=UO5CtkDG8SY1QylslsVPidl+DBFG4A3wfancxZTdfpauOwSdBYNyZVSURRB5tTR7ff aenWrABL+mHH2GSt2SStYd/ESUfdcy4VH9Eg7fRYoTpI1qvNO3NOUjcMfUPPLGe5sBeD bAR0gx5+MowuQ97oaBEZJVRfNsGYOaRy4uVdPlcVLye3wn5vCwwsHNaEQLzpRKEhAEfC S2JmkSdNLHU6WFeiIhsv0TKFxC5cRaNuyrrdPUjWvQ7jc4fjJnwszRnCNEUzLUtKAsl1 vtX8AlkEdeO8Eg+mImOMakCxYvqw5+8ThWdWyCx79VrlCKgnpLAmIKNinETqa/sI+IDD anHQ== X-Gm-Message-State: APjAAAVLy0A4yG//l/9A2WKL3KAE+6xQh51tDW67hpoclO5YzRoLB/K8 JKZeIB+4ojnqr3/CKNhigihwKVZW X-Google-Smtp-Source: APXvYqxM6z9Jvn4cA92l1OaFVl1WweqxuamhP2IxL0wm0VADJWq/vXU4ElhzkYcPQtTpOFdsOrniQg== X-Received: by 2002:a63:6bc3:: with SMTP id g186mr76061865pgc.21.1558509367639; Wed, 22 May 2019 00:16:07 -0700 (PDT) Received: from [192.168.1.105] (121-200-20-216.79c814.syd.nbn.aussiebb.net. [121.200.20.216]) by smtp.gmail.com with ESMTPSA id t18sm38391887pgm.69.2019.05.22.00.16.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 00:16:06 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r502238 - in head/x11: . py-pyscreenshot To: Alexey Dokuchaev , Steve Wills Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905220108.x4M18hFR056638@repo.freebsd.org> <20190522070947.GA31138@FreeBSD.org> From: Kubilay Kocak Message-ID: <95155332-148d-38f0-7fee-f07e931c1682@FreeBSD.org> Date: Wed, 22 May 2019 17:16:02 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: <20190522070947.GA31138@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB1676FAB2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; TAGGED_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 07:16:09 -0000 On 22/05/2019 5:09 pm, Alexey Dokuchaev wrote: > On Wed, May 22, 2019 at 01:08:43AM +0000, Steve Wills wrote: >> New Revision: 502238 >> URL: https://svnweb.freebsd.org/changeset/ports/502238 >> >> Log: >> x11/py-pyscreenshot: create port >> >> Pyscreenshot tries to allow to take screenshots without installing >> 3rd party libraries. > > O'rly, no 3rd party libs? > >> ... >> +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}easyprocess>0:devel/py-easyprocess@${PY_FLAVOR} \ >> + ${PYTHON_PKGNAMEPREFIX}pillow>0:graphics/py-pillow@${PY_FLAVOR} \ >> + import:graphics/ImageMagick6 > > Right, it would pull the whole ImageMagick on you instead. This port is > misguiding users and should probably not be added to the collection. Any > hand-written bindings around x11/imlib2 would fit the description better. > > ./danfe > pyscreenshots setup.py doesn't reference pillow, but a dependent port for which this was added (pyvirtualdisplay) does. I'm guessing it was inadvertent. I've already send Steve an email mentioning it Either way, not adding a port because the pkg-descr was wrong (I dont think it is however, given it doesn't depend on pillow) is a bit much. We'd just amend the pkg-descr not to make the claim thereby restoring balance to your force