From owner-freebsd-commit  Tue Nov 21 20:07:23 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id UAA25722
          for freebsd-commit-outgoing; Tue, 21 Nov 1995 20:07:23 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id UAA25704
          for cvs-all-outgoing; Tue, 21 Nov 1995 20:07:09 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id UAA25694
          for cvs-ports-outgoing; Tue, 21 Nov 1995 20:07:06 -0800
Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id UAA25673
          ; Tue, 21 Nov 1995 20:06:47 -0800
Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.12/8.6.9) id UAA01754; Tue, 21 Nov 1995 20:06:28 -0800
Date: Tue, 21 Nov 1995 20:06:28 -0800
Message-Id: <199511220406.UAA01754@silvia.HIP.Berkeley.EDU>
To: bde@zeta.org.au
CC: mark@grondar.za, CVS-commiters@freefall.freebsd.org,
        cvs-ports@freefall.freebsd.org, markm@freefall.freebsd.org
In-reply-to: <199511220225.NAA22683@godzilla.zeta.org.au> (message from Bruce Evans on Wed, 22 Nov 1995 13:25:30 +1100)
Subject: Re: URGENT: Re: cvs commit: ports/security/pidentd/patches patch-ae
From: asami@cs.berkeley.edu (Satoshi Asami)
Sender: owner-commit@FreeBSD.ORG
Precedence: bulk

Thanks for your reply, Bruce.  Much appreciated.

 * In 2.1, <sys/sysctl.h> included <sys/ucred.h>.  Including <sys/ucred.h>
 * doesn't work unless NGROUPS is already defined.  NGROUPS is a POSIX value
 * that is defined in (a file included by) <limits.h>.  It also happens to
 * be defined in (a file included by) <sys/param.h> and in <sys/syslimits.h>.
 * 
 * Mark apparently fixed a problem for 2.1 by removing <sys/sysctl.h>.  The
 * correct fix was probably to include <limits.h> or <sys/param.h> or to
 * complain until someone fixes <sys/ucred.h>.

Aahh.  I see that <sys/param.h> included after <sys/sysctl.h>, I
reversed the order and it works fine now.

 * KERN_FILE is defined in <sys/sysctl.h>.  <sys/sysctl.h> is not included by
 * any other header.

Oops, I'm sorry.  I forgot to update the ports directory in my machine
before my previous post.  It works fine in -current.  Mark's patch was
to add an include of <sys/sysctl.h>.

I changed the order of includes and it now works fine on both -current 
and -stable.  Thanks for your help.

Satoshi