From nobody Fri Sep 1 13:41:44 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RcfNG044kz4rHF0; Fri, 1 Sep 2023 13:42:22 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RcfNF3r3Vz4SQs; Fri, 1 Sep 2023 13:42:21 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-58fc4d319d2so21881137b3.1; Fri, 01 Sep 2023 06:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693575740; x=1694180540; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=fD5r31OK7q9F7ZHMAhtyc8UotIcJYQhBV14b0WZQp1Y=; b=R43uLdRFQ2Mz+cKYvehBP5bY//httes7Wl2Gm/4wjE9IX7MQ7qyrumGzv3zgrfyRJ5 TPcTZmdtuXrRKozJgrn2LkACQWEg6FIpl3NYs6loYUaJghutJFPwxiJaBEUN8qORE4wQ u4ZpIKU11lsUL7orLDqHHBnfr5ZA+lFpnRKw9w8L7MeEA41Rkfxv5Yi2FpbYvzmZbyWx wk+JF2rrPGVAT2undMwxBVVlFvZOAw8AX7IpwVVF+iCS4rRiE1nsLquNLOthct5MHXLY 1MkOGSTyTXlKWTRsNeQeR2E+n47an06jpeHfcLGA12nr8k9uQB+kTzP3wkxmG32cevCX 2PFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693575740; x=1694180540; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fD5r31OK7q9F7ZHMAhtyc8UotIcJYQhBV14b0WZQp1Y=; b=DjWyp5S9pwItRIjFjSTWJtp+IoLylu1k7RxZ2tPrlkTL4IPa+enn/jHHEOMYfkRUEy vBMwqhLN15y1i/goesjOakWousvT5RAD1nANjCZxiOlKbar9/o51lCyWSaKaHeI30dxW 6GNpwk9sZSUD5g3QzaaHCgUm23haf9+y7xDv5KHkd7qqUS6aEsF3GNwC3YjV9RikixVw NWJM+kgIWMk/bHZFzH7KNmE5Du0r/v96Sqmog3PIKj+F0zipIib6Q/o3RP1AQlJqVBDE pGj3XrME37c1hlOJdXR6iYceYyusOhaRD+k9Q+Q4uTOQ/oml4ZkFwuaHkYKJbgVjCTuJ /dkA== X-Gm-Message-State: AOJu0YyRU1vuOcscinzGRf8yFJKNos1GpeiiFwIfJcG5gIKZBhk4A9GW 9eFgQnUkOuAAJ+FhQo1/QJzMryGqFdHS9Q== X-Google-Smtp-Source: AGHT+IF63VCIHchL5wZd1oC6k28Mrcma+6QL9xzF27EH3/pSUN/3RqFBNizArNOab6ihP4QPtA6Uvg== X-Received: by 2002:a0d:e205:0:b0:58c:57c1:138a with SMTP id l5-20020a0de205000000b0058c57c1138amr2520679ywe.19.1693575740128; Fri, 01 Sep 2023 06:42:20 -0700 (PDT) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id r62-20020a0de841000000b005865494000dsm1071570ywe.115.2023.09.01.06.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Sep 2023 06:42:19 -0700 (PDT) Message-ID: <65269e7a-4c3f-95ff-3e81-91b76e023fbd@FreeBSD.org> Date: Fri, 1 Sep 2023 09:41:44 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Kyle Evans , Gleb Smirnoff , Martin Matuska Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Cy Schubert References: <202308270509.37R596B5048298@gitrepo.freebsd.org> From: Alexander Motin Subject: Re: git: 315ee00fa961 - main - zfs: merge openzfs/zfs@804414aad In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4RcfNF3r3Vz4SQs On 31.08.2023 22:18, Kyle Evans wrote: > It seems to have clearly been stomped on by uma trashing. Encountered > while running a pkgbase build, I think while it was in the packaging > phase. I note in particular in that frame: > > (kgdb) p/x lwb->lwb_issued_timestamp > $4 = 0xdeadc0dedeadc0de > > So I guess it was freed sometime during one of the previous two > zio_nowait() calls. Thank you, Kyle. If the source lines are resolved correctly and it really crashes on lwb_child_zio access, then I do see there a possible race condition, even though I think it would involve at least 2 or may be even 3 different threads. I've just created this new PR to address it: https://github.com/openzfs/zfs/pull/15233 If you'll be able to test it, include also the two previous: https://github.com/openzfs/zfs/pull/15227 https://github.com/openzfs/zfs/pull/15228 Thank you for something actionable, it really feels much better! :) -- Alexander Motin