From nobody Thu Apr 24 22:56:03 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZkBD703gkz5ttBL for ; Thu, 24 Apr 2025 22:56:23 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZkBD63xK8z3K7j for ; Thu, 24 Apr 2025 22:56:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4394a823036so15212105e9.0 for ; Thu, 24 Apr 2025 15:56:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745535375; x=1746140175; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kRF/fwn43XiZZMoEhtp/B3F7Du1uIx9UGOz+EuzMxbI=; b=JDJf3mvJ1A8vQG2LEasWtxHw1ckuOknFS6vg0MJ4I/VImGc7sl3F1A6dJCvG1hRiVj SYUcZkro07hPiUUqXq2Qk2+pKQiezSUtfvIWA2h9rET+Nx7cbGIpklgHUJRnmR3DGPMM iHx1ZXuyOOLLK/WLQzQPxPKUEYg2QjzWzOYhE7s22ckyR+K+LUagbnYA48w+Hri0TXWB D5qVS1US7VOBEMj8mt+aYfjbhcs/TRqhKkzZsOV1UoxehizkRjjD/nyKN2CS6MZQkRhm xwkkz+WeQNDghAtLHC47bn6pQNY46X5BlZjH7BapB3BMQ6sehB4n1hE8FvuYFF5o4c7V ao/g== X-Forwarded-Encrypted: i=1; AJvYcCVBoN5Vb14hr0/TmdZxBQmehQIVrh6vvnf+6MNWpMlFo0bjnzNRU2tWRBhbfHChw4Zg4RtcYDJblHhLtwIg8TSwWymj@freebsd.org X-Gm-Message-State: AOJu0Yx4+nzXpm289GCA8f6uKNJwt0Epagqm6sP9inanNeI6dPhfpbhc 9pMimEenCXdgDxBMKMwbO6zBdPgpEuTFSgNdpNlxxbYcDLdPRnY2EheYw2OOq5eQptSx+owsP+5 MVkc= X-Gm-Gg: ASbGncsqdyFEUN0/U/iaURgettjOuvlmJKZFF+GtHZshfVmWGnwWjw0OYtlaPQksWAA AF5wHGAm9e1xKHfG9m3PQDGTg8lw64vSMDXB5GmC1ncWaSjHzg3G1CmKkSVRdUtP2t2zcmFEZ5E mkvVHJCdugSLyylHIQjuPUd11wdSxE6ltsL6KZPCazhXFQIw/rpdw77iNXUZn5gcqFdcazs+KU1 UhE/eKPGyfP2igflKfnm6fmcHvbp5zMX8xdnnu1Eweot98jkLUHDD1grXvwZAG86PX5BtxOKOIz /pbQXo0Q+N37y4sIVyGPJN07napCYgepa1vBR5ClazfKOFPzbDbPxU4= X-Google-Smtp-Source: AGHT+IGvHoTGOzcx4UFsO12nUmm0EVIV+l3ppuTVp8m/sV4rMLSF59Q0nQE+NSi8DleAsVxYSld8LQ== X-Received: by 2002:a05:600c:35c4:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-440a66ab87bmr87715e9.31.1745535375453; Thu, 24 Apr 2025 15:56:15 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a53044besm3962825e9.14.2025.04.24.15.56.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Apr 2025 15:56:14 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh From: Jessica Clarke In-Reply-To: Date: Thu, 24 Apr 2025 23:56:03 +0100 Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202504220207.53M27okn077850@gitrepo.freebsd.org> To: Shawn Webb X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4ZkBD63xK8z3K7j X-Spamd-Bar: ---- On 24 Apr 2025, at 23:45, Shawn Webb wrote: > On Tue, Apr 22, 2025 at 02:07:50AM +0000, John Baldwin wrote: >> The branch main has been updated by jhb: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da098111a28ed59e1ab1101ad09913f02= 35ebd28f >>=20 >> commit a098111a28ed59e1ab1101ad09913f0235ebd28f >> Author: John Baldwin >> AuthorDate: 2025-04-22 02:05:28 +0000 >> Commit: John Baldwin >> CommitDate: 2025-04-22 02:05:28 +0000 >>=20 >> secure: Add ssh-sk-client to all consumers of libssh >>=20 >> These all failed to link with ld.bfd used by GCC due to >> Fssh_sshsk_sign being an unresolved symbol. >>=20 >> Fixes: 65d8491719bb ("secure: Adapt Makefile to = ssh-sk-client everywhere") >=20 > Hey John, >=20 > I'm getting the following error from the RTLD when the rc scripts > start sshd: >=20 > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > ld-elf.so.1: /usr/lib/libprivatessh.so.5: Undefined symbol = "Fssh_sshsk_sign > =3D=3D=3D=3D END LOG =3D=3D=3D=3D >=20 > This is on HardenedBSD 15-CURRENT/amd64. I'll try to reproduce next > week with vanilla FreeBSD, unless someone else beats me to it. I don=E2=80=99t understand how this is meant to work. sshsk_sign is used = by sshkey.c, which is in libssh, so why are we putting the definition of sshsk_sign (namespaced) in each and every program? Jess