From owner-freebsd-ports Thu Aug 29 1:58:48 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA04437B400; Thu, 29 Aug 2002 01:58:42 -0700 (PDT) Received: from gatesrv.RZ.UniBw-Muenchen.de (gatesrv.RZ.UniBW-Muenchen.de [137.193.11.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46D1543E4A; Thu, 29 Aug 2002 01:58:41 -0700 (PDT) (envelope-from lizard@informatik.unibw-muenchen.de) Received: from nemesis.informatik.unibw-muenchen.de (nemesis.Informatik.UniBw-Muenchen.de [137.193.60.30]) by gatesrv.RZ.UniBw-Muenchen.de (8.11.2/8.11.2) with ESMTP id g7T8uQo14885; Thu, 29 Aug 2002 10:56:26 +0200 (MEST) Received: from localhost (localhost.informatik.unibw-muenchen.de [127.0.0.1]) by nemesis.informatik.unibw-muenchen.de (Postfix) with ESMTP id 20DF05A549; Thu, 29 Aug 2002 10:56:25 +0200 (CEST) Received: by nemesis.informatik.unibw-muenchen.de (Postfix, from userid 1001) id 401035A547; Thu, 29 Aug 2002 10:56:24 +0200 (CEST) Date: Thu, 29 Aug 2002 10:56:24 +0200 From: Oliver Braun To: ports@freebsd.org Cc: lioux@freebsd.org, B.Candler@pobox.com, dwcjr@freebsd.org, jos@catnook.com Subject: Please review patch (was: ports/42074: rsync depends on many other packages - popt dependencies?) Message-ID: <20020829085624.GA63657@informatik.unibw-muenchen.de> Mail-Followup-To: Oliver Braun , ports@freebsd.org, lioux@freebsd.org, B.Candler@pobox.com, dwcjr@freebsd.org, jos@catnook.com References: <200208271204.g7RC4jBG049111@www.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VrqPEDrXMn8OVzN4" Content-Disposition: inline In-Reply-To: <200208271204.g7RC4jBG049111@www.freebsd.org> Organization: University of the Federal Armed Forces Munich, Germany X-Mailer: Mutt http://www.mutt.org/ X-OS: FreeBSD 4.6-STABLE i386 http://www.freebsd.org/ X-Newsreader: SLRN http://www.slrn.org/ X-PGP-Key: http://pgpkeys.mit.edu:11371/pks/lookup?op=get&search=0xEF25B1BA X-PGP-Fingerprint: 6A3B 042A 732E 17E4 B6E7 3EAF C0B1 6B7D EF25 B1BA X-Uptime: 7 days X-URL: http://ist.unibw-muenchen.de/People/obraun X-Accept-Language: de en X-Location: Europe, Germany, Munich X-Editor: Vim-601 http://www.vim.org/ User-Agent: Mutt/1.5.1i X-Virus-Scanned: by AMaViS snapshot-20020531 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --VrqPEDrXMn8OVzN4 Content-Type: multipart/mixed; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline --AqsLC8rIMeq19msA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Brian Candler [2002-08-27 14:04 +0200]: > Possibly as a result of change ports/37348, rsync now depends on a > whole bunch of other packages including an XML parser! > This is a bit of a pain in a server environment where you want to > install the minimum amount of shrapnel. libpopt I will accept, but > the rest seem irrelevant to rsync. > expat/libiconv/gettext are dependencies of popt, so I guess the > question really is why a command-line option parser depends on those > things? Find attached a patch I want to commit: * define WITH_POPT_PORT to build net/rsync with devel/popt and all dependencies. * default behaviour is to use included popt. So, the package does not depend on devel/popt Lioux, does devel/popt need all these dependencies, or is it possible to remove the dependency on gettext at least by default and make gettext support optional? As I have mentioned before in my previous mail, the rsync developers want to drop the included version of popt in one of the next upcoming releases. Maybe we can argue them to keep popt (Jos)? Anyone any comments? If everyone is happy and David approves it, I am going to commit the patch this weekend, so that 4.7-R packages won't depend on popt/expat/libiconv/gettext. Regards, Olli --=20 =AB: IST & IIS _ INF _ UniBwM :: obraun@informatik.unibw-muenchen.de := =BB =AB: Tele-Consulting GmbH :: obraun@Tele-Consulting.com := =BB =AB: FreeBSD Commmitter :: obraun@FreeBSD.org := =BB --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff Content-Transfer-Encoding: quoted-printable Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/net/rsync/Makefile,v retrieving revision 1.76 diff -u -r1.76 Makefile --- Makefile 21 Aug 2002 14:46:05 -0000 1.76 +++ Makefile 29 Aug 2002 08:32:49 -0000 @@ -17,12 +17,18 @@ =20 MAINTAINER=3D obraun@FreeBSD.org =20 +.if defined(WITH_POPT_PORT) LIB_DEPENDS=3D popt.0:${PORTSDIR}/devel/popt +.endif =20 USE_REINPLACE=3D yes GNU_CONFIGURE=3D yes +.if defined(WITH_POPT_PORT) CONFIGURE_ENV=3D CFLAGS=3D"-I${LOCALBASE}/include" \ LIBS=3D"-L${LOCALBASE}/lib" +.else +CONFIGURE_ARGS=3D --with-included-popt +.endif =20 .include =20 @@ -37,12 +43,19 @@ .endif =20 .if ${OSVERSION} >=3D 400014 -CONFIGURE_ARGS=3D --disable-debug --enable-ipv6 +CONFIGURE_ARGS+=3D --disable-debug --enable-ipv6 .else -CONFIGURE_ARGS=3D --disable-debug --disable-ipv6 +CONFIGURE_ARGS+=3D --disable-debug --disable-ipv6 .endif MAN1=3D rsync.1 MAN5=3D rsyncd.conf.5 + +.if !defined(WITH_POPT_PORT) +pre-everything:: + @${ECHO_CMD} "rsync comes with an included version of popt." + @${ECHO_CMD} "To build rsync with devel/popt instead," + @${ECHO_CMD} "hit Ctrl-C now and define WITH_POPT_PORT" +.endif =20 pre-configure: @${REINPLACE_CMD} -e 's:/etc/:${PREFIX}/etc/:g' \ --AqsLC8rIMeq19msA-- --VrqPEDrXMn8OVzN4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9beG4wLFrfe8lsboRAupuAKCBzp8QxpP9px4KOvYCurDbSp2PAgCgiUoc nDR9xr+F8RFOJs+FFnIiBEc= =pb3r -----END PGP SIGNATURE----- --VrqPEDrXMn8OVzN4-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message