From owner-freebsd-net@FreeBSD.ORG Thu Jun 5 23:51:05 2003 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8065937B401 for ; Thu, 5 Jun 2003 23:51:05 -0700 (PDT) Received: from mwinf0204.wanadoo.fr (smtp7.wanadoo.fr [193.252.22.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7491543F75 for ; Thu, 5 Jun 2003 23:51:04 -0700 (PDT) (envelope-from vjardin@wanadoo.fr) Received: from venus.vincentjardin.net (unknown [193.253.255.167]) by mwinf0204.wanadoo.fr (SMTP Server) with ESMTP id DB859A00006B; Fri, 6 Jun 2003 08:51:02 +0200 (CEST) Content-Type: text/plain; charset="iso-8859-1" From: Vincent Jardin To: Julian Elischer , Michael Shiu Date: Fri, 6 Jun 2003 08:51:30 +0200 User-Agent: KMail/1.4.3 References: In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200306060851.30777.vjardin@wanadoo.fr> cc: freebsd-net@freebsd.org Subject: Re: Does Netgraph in FBSD 5.x SMP requires GIANT lock? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2003 06:51:05 -0000 > > it should not require Giant. > However there are some locking 'holes' that come when locked resources > are accessed by external code that is executed from other contexts.. > e.g. many drivers do not know about the locks in their netgraph half, > and just 'do' what they want. Also there are instances of callout > (timeout) code doing things to a node without getting teh node's lock. > What's about ng_l2tp ? The BSD's callout functions are used instead of the Netgraph's=20 ng_[un]timeout functions.=20 Vincent