From owner-freebsd-current  Mon Mar 17  5: 9:49 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A1F1037B401; Mon, 17 Mar 2003 05:09:47 -0800 (PST)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9E0F843FBF; Mon, 17 Mar 2003 05:09:46 -0800 (PST)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h2HD9YA7018462;
	Mon, 17 Mar 2003 06:09:34 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Mon, 17 Mar 2003 06:07:44 -0700 (MST)
Message-Id: <20030317.060744.07210205.imp@bsdimp.com>
To: sam@errno.com
Cc: bright@mu.org, sam@freebsd.org, current@freebsd.org
Subject: Re: wi driver
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <33c601c2ec46$0d48dce0$52557f42@errno.com>
References: <20030317051920.GN4145@elvis.mu.org>
	<20030317052534.GO4145@elvis.mu.org>
	<33c601c2ec46$0d48dce0$52557f42@errno.com>
X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In message: <33c601c2ec46$0d48dce0$52557f42@errno.com>
            "Sam Leffler" <sam@errno.com> writes:
: > * Alfred Perlstein <bright@mu.org> [030316 21:19] wrote:
: > > um..
: > >
: > ...
: > 840     _FLAGS_OUTRANGE) {
: > 841                     WI_UNLOCK(sc);
: > 842                     return;
: > 843             }
: > 844             KASSERT((ifp->if_flags & IFF_OACTIVE) == 0,
: > 845                     ("wi_start: if_flags %x\n", ifp->if_flags));
: > 846
: > 847             memset(&frmhdr, 0, sizeof(frmhdr));
: >
: > >
: > > What's up here?
: >
: > It's a race, we shouldn't be inspecting the ifp without a lock.
: >
: > I think this kassert should be removed.
: >
: > Do you guys concurr?
: 
: Warner has this pending with some other fixes; perhaps he can accelerate
: doing the commit?  The assert is actually just bogus (if_start can be called
: under certain conditions with IFF_OACTIVE set.

This is part of my commit.  The KASSERT is totally bogus.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message