From owner-svn-src-head@FreeBSD.ORG  Tue Jul 28 18:21:36 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B151110656BF
	for <svn-src-head@freebsd.org>; Tue, 28 Jul 2009 18:21:36 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outP.internet-mail-service.net (outp.internet-mail-service.net
	[216.240.47.239])
	by mx1.freebsd.org (Postfix) with ESMTP id 9644E8FC24
	for <svn-src-head@freebsd.org>; Tue, 28 Jul 2009 18:21:36 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id 5D416C3FB;
	Tue, 28 Jul 2009 11:07:06 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 920292D601F;
	Tue, 28 Jul 2009 11:07:05 -0700 (PDT)
Message-ID: <4A6F3E4D.3050803@elischer.org>
Date: Tue, 28 Jul 2009 11:07:09 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
MIME-Version: 1.0
To: Tor Egge <Tor.Egge@cvsup.no.freebsd.org>
References: <200907250642.n6P6ggKw032784@svn.freebsd.org>
	<20090728.170954.74706437.Tor.Egge@cvsup.no.freebsd.org>
In-Reply-To: <20090728.170954.74706437.Tor.Egge@cvsup.no.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, julian@freebsd.org
Subject: Re: svn commit: r195862 - head/sys/netinet/ipfw
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2009 18:21:37 -0000

Tor Egge wrote:
> This commit causes my laptop to hang during boot.
> 
> ipfw and ipfw_nat are both compiled into the kernel:
> 
> options         IPFIREWALL
> options         IPFIREWALL_VERBOSE
> options         IPFIREWALL_VERBOSE_LIMIT=100
> options         IPFIREWALL_FORWARD
> options         IPFIREWALL_NAT
> options         IPDIVERT
> 
> The kernel hangs during
> 
>     IPFW_WLOCK(&V_layer3_chain);
> 
> at the start of ipfw_nat_init.  The lock is not yet initialized at this time
> (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY), since the commit moved the
> initialization of the lock from
> (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256) (cf. ipfw_modevent() calling
> ipfw_init()) to (SI_SUB_KTHREAD_INIT, SI_ORDER_ANY) (cf. vnet_ipfw_init()).
> 
> - Tor Egge

hmmm odd, runs here...

I'll check it right now
I wonder whats diff...... ooooooh my last tests were with ipfw as a 
module.....


ok I wonder where the "right" place to add it is.. probably keep it
at  SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256.

an you check if that fixes it?  possibly moving the 256 to 255?