From owner-cvs-all@FreeBSD.ORG Thu Apr 17 13:32:08 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08CB237B401; Thu, 17 Apr 2003 13:32:08 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A263343F3F; Thu, 17 Apr 2003 13:32:07 -0700 (PDT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h3HKW70U066777; Thu, 17 Apr 2003 13:32:07 -0700 (PDT) (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h3HKW7ex066776; Thu, 17 Apr 2003 13:32:07 -0700 (PDT) Message-Id: <200304172032.h3HKW7ex066776@repoman.freebsd.org> From: Nate Lawson Date: Thu, 17 Apr 2003 13:32:07 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2003 20:32:08 -0000 njl 2003/04/17 13:32:07 PDT FreeBSD src repository Modified files: sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c Log: Revise attach/detach resource cleanup - Unconditionally call *_stop() if device is in the tree. This is to prevent callouts from happening after the device is gone. Checks for bus_child_present() should be added in the future to keep from touching potentially non-existent hardware in *_detach(). Found by iedowse@. - Always check for and free miibus children, even if the device is not in the tree since some failure cases could have gotten here. - Call ether_ifdetach() in the irq setup failure case - ti(4), xl(4): move ifmedia_init() calls to the beginning of attach so that ifmedia_removeall() can be unconditionally called on detach. There is no way to detect whether ifmedia has been initialized without using a separate variable (as tl(4) does). - Add comments to indicate assumptions of code path Revision Changes Path 1.103 +12 -2 src/sys/pci/if_dc.c 1.43 +15 -6 src/sys/pci/if_pcn.c 1.97 +14 -4 src/sys/pci/if_rl.c 1.55 +14 -4 src/sys/pci/if_sf.c 1.73 +15 -6 src/sys/pci/if_sis.c 1.60 +14 -4 src/sys/pci/if_sk.c 1.51 +14 -4 src/sys/pci/if_ste.c 1.77 +13 -5 src/sys/pci/if_ti.c 1.82 +14 -4 src/sys/pci/if_tl.c 1.70 +14 -4 src/sys/pci/if_vr.c 1.59 +17 -5 src/sys/pci/if_wb.c 1.142 +17 -10 src/sys/pci/if_xl.c