From owner-cvs-all@FreeBSD.ORG Thu Mar 27 08:58:01 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F05437B401; Thu, 27 Mar 2003 08:58:01 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 142FF43F85; Thu, 27 Mar 2003 08:58:01 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id CC0392ED3CF; Thu, 27 Mar 2003 08:58:00 -0800 (PST) Date: Thu, 27 Mar 2003 17:58:00 +0100 From: Maxime Henrion To: Bosko Milekic Message-ID: <20030327165800.GK57674@elvis.mu.org> References: <200303260452.h2Q4quap015364@www.ambrisko.com> <20030326114030.U2075@odysseus.silby.com> <20030326183351.GJ57674@elvis.mu.org> <20030326130903.G2075@odysseus.silby.com> <20030327013224.P7674@odysseus.silby.com> <20030327164402.GA15454@unixdaemons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030327164402.GA15454@unixdaemons.com> User-Agent: Mutt/1.4i X-Spam-Status: No, hits=-32.5 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_MUTT version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: src-committers@freebsd.org cc: Doug Ambrisko cc: cvs-src@freebsd.org cc: Sam Leffler cc: Mike Silbersack cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2003 16:58:03 -0000 Bosko Milekic wrote: > > Can you please still use m_gethdr() or m_getcl() to do the allocations > in the defragment function? Similarly, for > MCLBYTES, use m_getm(). > Don't roll your own. Please see my reply to Mike for the first version of his patch. He couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it panic if we have a cluster attached to the mbuf. Cheers, Maxime