From owner-cvs-all Thu Jan 24 14:11: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id CB5F137B733; Thu, 24 Jan 2002 14:00:26 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0OLwoT87385; Fri, 25 Jan 2002 00:58:51 +0300 (MSK) (envelope-from ache) Date: Fri, 25 Jan 2002 00:58:49 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_opieaccess pam_opieaccess.c Message-ID: <20020124215848.GA87344@nagual.pp.ru> References: <200201241618.g0OGIi276333@freefall.freebsd.org> <20020124212631.GA86757@nagual.pp.ru> <20020124215212.GC87013@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020124215212.GC87013@nagual.pp.ru> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jan 25, 2002 at 00:52:13 +0300, Andrey A. Chernov wrote: > > I did it this way because opieaccessfile() always accepts an empty > > (not NULL) host, but you're right. > > Hmm, yes. I think they do improper thing here always accepting "" since > non-PAMed "ftp localhost" (see opieftpd.c) f.e. just not use this empty > host part, so local.host.name addition to /etc/opieaccess needed in any > case. I.e. accepting empty host does nothing for services which fills > remote host. It seems they try to just cover seamless integration for > programs that forget to set remote host. I mean, in that case your variant is right, but will be better to do it that way: if (rhost == NULL) rhost = ""; Because they can change "" acceptance in the opieaccessfile() in the later OPIE versions. I.e. better way is not repeat current OPIE functionality, on upper level, but let OPIE itself decide. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message