From owner-svn-src-stable@FreeBSD.ORG Wed Nov 30 17:11:00 2011 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EFE2106566B; Wed, 30 Nov 2011 17:11:00 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id 283C38FC15; Wed, 30 Nov 2011 17:10:59 +0000 (UTC) Received: by eaai12 with SMTP id i12so1363471eaa.13 for ; Wed, 30 Nov 2011 09:10:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.14.203 with SMTP id h11mr533967eba.139.1322671705249; Wed, 30 Nov 2011 08:48:25 -0800 (PST) Received: by 10.14.37.136 with HTTP; Wed, 30 Nov 2011 08:48:25 -0800 (PST) X-Originating-IP: [209.66.78.50] In-Reply-To: <20111117183642.GY1455@elvis.mu.org> References: <20111117040109.GU1455@elvis.mu.org> <462306074.1954190.1321506994004.JavaMail.root@erie.cs.uoguelph.ca> <20111117183642.GY1455@elvis.mu.org> Date: Wed, 30 Nov 2011 11:48:25 -0500 Message-ID: From: Mark Saad To: Alfred Perlstein Content-Type: text/plain; charset=UTF-8 Cc: svn-src-stable-7@freebsd.org, src-committers@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Rick Macklem , Rick Macklem Subject: Re: svn commit: r227549 - stable/7/sys/nfsclient X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 17:11:00 -0000 On Thu, Nov 17, 2011 at 1:36 PM, Alfred Perlstein wrote: > * Rick Macklem [111116 21:16] wrote: >> Alfred Perlstein wrote: >> > Rick, I have a question, what will happen if the nfs_freesillyrename() >> > call happens when the mount is down? Will it block the >> > taskqueue_thread? >> > >> > If so, it might make more sense to make a taskqueue per mount point. >> > >> > If not, excuse me. :-) >> > >> Well, all nfs_freesillyrename() does is a vrele() on the parent >> directory when the file node's use count has gone to 0. >> I can't think why that would do any RPC, so I don't see a problem? >> If you do see a problem with vrele() on the directory, please let me >> know. >> >> The problem this fixes is a LOR that would occur when the vrele() on >> the directory was done by the thread doing VOP_INACTIVE(), since it >> already has the file vnode lock and the vrele() was locking the parent >> directory. This could cause a fairly rare deadlock. > > Yes, I understand the VFS deadlock. > > I see, I didn't realize the call was against the directory, > thank you for explaining. > > -Alfred Rick Any chance this will make it back into 7.3-RELEASE and 7.4-RELEASE ? -- mark saad | nonesuch@longcount.org