From owner-svn-ports-head@freebsd.org Thu Aug 4 14:59:23 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A593CBAFB95; Thu, 4 Aug 2016 14:59:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7356B172D; Thu, 4 Aug 2016 14:59:23 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id i6so18366460pfe.0; Thu, 04 Aug 2016 07:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pzdi1ElyOpA5rUIA551s9hSrHHLhEnaJXWk40Nfm75I=; b=W9/mdDY6zcSyW354MSGx+fIXwUpUOGlnqIHX3VLPat5oQA20gUvCPHTbblyi/+lr+C ue2Tq3fWKs8N38xtmSxGsgRA+Fm8uPuQIxBwqM8ZmpRBfw5vc5XBFdrxGYb40/yfwHfJ ATXVW7MPWEkBNGlczB5MP6XLoE2oFeZNwBKTPUk+Lt2AhnZXEhfpj20WMOlx8pKf9qBi nA0DnQZtyq1wdJs/k3u3u4rpSUn2pQpEadvS2XCK3zDymXLnMV18w3y8jiZYwn7Gx4IZ GPR3Eyo18lbQerkib1SnWlTZAYdLXC+o+nGYfBL0SDpTh6kwlldQsoJoNYyDkes0Nnkp vrWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pzdi1ElyOpA5rUIA551s9hSrHHLhEnaJXWk40Nfm75I=; b=NqKJV286BBpxtLdvc3oxg5RYKCFdTf+Hr7OPRsRgn1vEMSMFUdLpQwT2tnEKX6pMWM n8cNYutuI3NiXUICNMhM81zAVkkxxJkj5riSwQDybG93XCD9tMyoe5oqPwHwz6meIalI 0BKCscrQUgnJ5RzIVpLOzt5hqHhJGKgVn51oq4CNIVlP2jGkUiWryZR+q2QdZbHjad01 PVzUqZLYxR5Ueq3eu3mzkhzwIuRpE5tUdFE3Yd3b/9GCfbBYwtQ3O66wdWg1VMDIEgqe ERP0Gudns1qOT+hl+xZzK2Iy2lJXjazCqhUh6fwtfFQ41tBHBRQe2mNmULQ1UGQz9L8W 9yHQ== X-Gm-Message-State: AEkooutRz+2I3t63yBw4C+IGfD1qaAeCo3bzEYMz0dbuYD2aKW6VB61QEkiHl57iRwS44A== X-Received: by 10.98.47.132 with SMTP id v126mr127819071pfv.152.1470322762920; Thu, 04 Aug 2016 07:59:22 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:f985:3c4b:2a0c:8bea? (2001-44b8-31ae-7b01-f985-3c4b-2a0c-8bea.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:f985:3c4b:2a0c:8bea]) by smtp.gmail.com with ESMTPSA id 81sm21087849pfm.90.2016.08.04.07.59.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Aug 2016 07:59:22 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r419614 - head/net-mgmt/netams References: <201608041418.u74EIXB3055452@repo.freebsd.org> To: John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kubilay Kocak Message-ID: <854495f4-7b47-a5b4-abe0-59624713a28d@FreeBSD.org> Date: Fri, 5 Aug 2016 00:59:07 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0a2 MIME-Version: 1.0 In-Reply-To: <201608041418.u74EIXB3055452@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2016 14:59:23 -0000 On 5/08/2016 12:18 AM, John Marino wrote: > Author: marino > Date: Thu Aug 4 14:18:33 2016 > New Revision: 419614 > URL: https://svnweb.freebsd.org/changeset/ports/419614 > > Log: > net-mgmt/netams: reset maintainer, expire, make less broken > > First, the port already has 3 maintainer timeouts going back years, so > go ahead and reset maintainership. > > Second, it's broken on FreeBSD 10 and newer. > > Third, the options were broken (e.g. USES defined after , > 
 and  also used with options.  I tweaked this some (untested)
>   
>   Fourth: The pcap specification is ambiguous.  (I removed it). [1]
>   
>   The entire port is in really bad shape so set it for removal in
>   two weeks.

I think 2 weeks is too short for users who may use this and in general.

Can you please set this to at least 3 months, so there is an opportunity
for users to see the 'port is unmaintained' message and call to action.

>   PR:	211578 [1]
> 
> Modified:
>   head/net-mgmt/netams/Makefile
> 
> Modified: head/net-mgmt/netams/Makefile
> ==============================================================================
> --- head/net-mgmt/netams/Makefile	Thu Aug  4 14:05:19 2016	(r419613)
> +++ head/net-mgmt/netams/Makefile	Thu Aug  4 14:18:33 2016	(r419614)
> @@ -3,16 +3,21 @@
>  
>  PORTNAME=	netams
>  PORTVERSION=	3.4.5
> -PORTREVISION=	3
> +PORTREVISION=	4
>  CATEGORIES=	net-mgmt
>  MASTER_SITES=	http://www.netams.com/files/
>  
> -MAINTAINER=	jura@netams.com
> +MAINTAINER=	ports@FreeBSD.org
>  COMMENT=	Network Traffic Accounting and Monitoring Software
>  
> -LICENSE=	GPLv2
> +BROKEN_FreeBSD_10=	PR 197249
> +BROKEN_FreeBSD_11=	PR 197249
> +BROKEN_FreeBSD_12=	PR 197249

See Bugzilla Issue: 197249 might be clearer for users who dont know what
a PR is.

> +DEPRECATED=	unmaintained, broken on most FreeBSD platforms

Although 'most' could be argued to be technically true, only 10.x and
9.x are supported production branches at the moment, and only 50% of
those is broken.

Broken on FreeBSD >= 10 (as mentioned in your commit log) is more accurate.

> +EXPIRATION_DATE=	2016-08-18
>  
> -LIB_DEPENDS=	libpcap.so:net/libpcap
> +LICENSE=	GPLv2
>  
>  SSP_UNSAFE=	kernel module does not support ssp
>  USE_SUBMAKE=	yes
> @@ -32,6 +37,7 @@ CGI_DESC=	Install admin/user CGI scripts
>  OPTIONS_SUB=	yes
>  PGSQL_USES=	pgsql
>  MYSQL_USE=	MYSQL=yes
> +CGI_USES=	jpeg
>  
>  .include 
>  
> @@ -73,7 +79,6 @@ RUN_DEPENDS+=	p5-GD>=0:graphics/p5-GD \
>  		p5-Crypt-GeneratePassword>=0:security/p5-Crypt-GeneratePassword
>  
>  LIB_DEPENDS+=	libgd.so:graphics/gd
> -USES+=		jpeg
>  
>  . if ${PORT_OPTIONS:MPGSQL}
>  RUN_DEPENDS+=	p5-DBD-Pg>=0:databases/p5-DBD-Pg
> @@ -136,10 +141,4 @@ do-install:
>  .endif
>  	${INSTALL_MAN} ${MAN_8:S|^|${WRKSRC}/doc/|} ${STAGEDIR}${PREFIX}/man/man8
>  
> -.include 
> -
> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000000
> -BROKEN=		does not build on 10.x+
> -.endif
> -
> -.include 
> +.include 
>