From owner-cvs-all Wed Sep 18 7: 9:30 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B58DE37B401 for ; Wed, 18 Sep 2002 07:09:28 -0700 (PDT) Received: from south.nanolink.com (south.nanolink.com [217.75.134.10]) by mx1.FreeBSD.org (Postfix) with SMTP id 12B1443E3B for ; Wed, 18 Sep 2002 07:09:27 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 77952 invoked by uid 85); 18 Sep 2002 14:18:06 -0000 Received: from office.sbnd.net (HELO straylight.ringlet.net) (217.75.140.130) by south.nanolink.com with SMTP; 18 Sep 2002 14:18:04 -0000 Received: (qmail 14820 invoked by uid 1000); 18 Sep 2002 14:08:10 -0000 Date: Wed, 18 Sep 2002 17:08:10 +0300 From: Peter Pentchev To: Dan Langille Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/devel/gindent Makefile pkg-plist ports/devel/gindent/files patch-doc:Makefile.in Message-ID: <20020918140809.GB13373@straylight.oblivion.bg> Mail-Followup-To: Dan Langille , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200209181232.g8ICWbq4059604@freefall.freebsd.org> <3D88438C.16000.41888E90@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hQiwHBbRI9kgIhsi" Content-Disposition: inline In-Reply-To: <3D88438C.16000.41888E90@localhost> User-Agent: Mutt/1.5.1i X-Virus-Scanned: by Nik's Monitoring Daemon (AMaViS perl-11d ) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --hQiwHBbRI9kgIhsi Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2002 at 09:12:44AM -0400, Dan Langille wrote: > On 18 Sep 2002 at 5:32, Peter Pentchev wrote: >=20 > > roam 2002/09/18 05:32:37 PDT > >=20 > > Modified files: > > devel/gindent Makefile pkg-plist=20 > > devel/gindent/files patch-doc:Makefile.in=20 > > Log: > > Support CFLAGS/CXXFLAGS properly. > > Honor NOPORTDOCS. >=20 > Waking up this morning, FreshPorts tells me[1] there is a problem=20 > with this port: >=20 > [dan@undef:~/ports/devel/gindent] $ make -V PORTVERSION > "/usr/home/dan/ports/devel/gindent/Makefile", line 36: Malformed=20 > conditional (!defiend(NOPORTDOCS)) Yeah, well.. *censored*.. I guess that serves me well for trying to fix an obvious omission on the PR submitter's part (no .ifdef NOPORTDOCS around the post-install target) right before the commit, with not even an attempt at a test :( OK, I will fix it as soon as we're done with some FreshPorts tests that Dan has asked me to help with. [snip] > [1] - FreshPorts would have told roam if he was opt'd in at=20 > FreshPorts. FreshPorts runs a sanity test on every port commit. If=20 > a commiter opts in, any errors found in their commits are reported=20 > directly to them instead of me being the go between. I urge every=20 > port committer to opt in. It saves me the bother of reporting your=20 > errors to you and the world. It also means the problem is fixed much=20 > sooner. At present, we have 15 opt'd in committers, where are the=20 > rest of you? And although I had to learn about this FreshPorts service the hard way, may I use this opportunity to join Dan in his plea. This is indeed a good service, almost real-time notification of both trivial errors and obscure things like the pre-everything double-colon problems of yore. Just jump in and do it :) G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 I am jealous of the first word in this sentence. --hQiwHBbRI9kgIhsi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9iIjJ7Ri2jRYZRVMRAkgFAJ9KG0K3h3KybWMKOMgNzJypGynQawCfZUHV 3ZwShonDQSmaOaLzGLMCRCA= =p4fk -----END PGP SIGNATURE----- --hQiwHBbRI9kgIhsi-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message