From owner-freebsd-hackers  Wed Jan 16 11:37: 5 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205])
	by hub.freebsd.org (Postfix) with ESMTP id D139437B404
	for <hackers@freebsd.org>; Wed, 16 Jan 2002 11:37:00 -0800 (PST)
Received: (qmail 7007 invoked from network); 16 Jan 2002 19:36:59 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <mjacob@feral.com>; 16 Jan 2002 19:36:59 -0000
Message-ID: <XFMail.020116113616.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <Pine.BSF.4.21.0201161100480.7823-100000@beppo>
Date: Wed, 16 Jan 2002 11:36:16 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Matthew Jacob <mjacob@feral.com>
Subject: RE: multilpe ddb_regs definitions
Cc: Peter Wemm <peter@netplex.com.au>, hackers@freebsd.org
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG


On 16-Jan-02 Matthew Jacob wrote:
> 
> I've had problems compiling alpha kernels for the last week or so- this
> occurs (with or w/o DDB optioned in).
> 
> subr_pcpu.o: In function `pcpu_init':
> /tstsys/alpha/compile/GPLUS/../../../kern/subr_pcpu.c(.data+0x8): multiple
> definition of `ddb_regs'
> kern_mutex.o:/tstsys/alpha/compile/GPLUS/../../../kern/kern_mutex.c:127:
> first
> defined here
> subr_witness.o: In function `witness_init':
> /tstsys/alpha/compile/GPLUS/../../../kern/subr_witness.c:349: multiple
> definition of `ddb_regs'
> kern_mutex.o:/tstsys/alpha/compile/GPLUS/../../../kern/kern_mutex.c:127:
> first
> defined here
> tty_cons.o: In function `cnadd':
> /tstsys/alpha/compile/GPLUS/../../../kern/tty_cons.c:199: multiple definition
> of `ddb_regs'
> kern_mutex.o:/tstsys/alpha/compile/GPLUS/../../../kern/kern_mutex.c:127:
> first
> defined here
> machdep.o: In function `alpha_init':
> /tstsys/alpha/compile/GPLUS/../../../alpha/alpha/machdep.c:527: multiple
> definition of `ddb_regs'
> kern_mutex.o:/tstsys/alpha/compile/GPLUS/../../../kern/kern_mutex.c:127:
> first
> defined here
> 
> 
> I haven't really tracked down what is different or broken, but I notice that
> ddb_regs is defined as common storage in <machine/db_machdep.h> (whether DDB
> is optioned to exist or not).
> 
> Instead, shouldn't that be an 'extern' reference and ddb_regs put some place
> like machdep.c along with the other DDB option'd vars?

Yes.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message