From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 12 05:32:14 2013 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 485BAC10; Sun, 12 May 2013 05:32:14 +0000 (UTC) (envelope-from FreeBSD@shaneware.biz) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [IPv6:2001:44b8:8060:ff02:300:1:6:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4C95FB52; Sun, 12 May 2013 05:32:13 +0000 (UTC) Received: from ppp247-71.static.internode.on.net (HELO leader.local) ([203.122.247.71]) by ipmail05.adl6.internode.on.net with ESMTP; 12 May 2013 15:02:11 +0930 Message-ID: <518F295B.4040501@ShaneWare.Biz> Date: Sun, 12 May 2013 15:02:11 +0930 From: Shane Ambler User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Raphael Kubo da Costa Subject: Re: ports/178505: [maintainer update] for graphics/openimageio References: <201305112110.r4BLA1Vs001652@freefall.freebsd.org> In-Reply-To: <201305112110.r4BLA1Vs001652@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ports-bugs@FreeBSD.org, bug-followup@FreeBSD.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 May 2013 05:32:14 -0000 On 12/05/2013 06:38, Raphael Kubo da Costa wrote: > Is the change to thread.h supposed to work on non-amd64 FreeBSD? Has > the patch been sent upstream? Short - yes and yes. Long - The patch originated with the discovery that i386 version crashed using tbb. The addition of arch=i586 to cflags enabled the use of gcc atomics. This was merged into the cmake files (src/cmake/platform.cmake) in 1.1.6 and taken out of the port makefile. 1.1.6 also included the removal of the freebsd condition in thread.h and by Larry Gritz's choice it was replaced with a test that left gcc atomics off if tbb was turned on. Disabling gcc atomics when tbb is on turned out to be a performance hit and 1.1.7 replaced the freebsd condition instead of removing the tbb test. I have submitted an issue for it (instead of a pull request) which seems to be the slow way of getting a change. While 1.1.8 appeared to be cli tools fixes and 1.1.9 was only docs, I don't want to drop behind so updating here with the patch.