From owner-cvs-all Thu Jul 20 9:31:36 2000
Delivered-To: cvs-all@freebsd.org
Received: from storm.FreeBSD.org.uk (storm.freebsd.org.uk [194.242.139.170])
by hub.freebsd.org (Postfix) with ESMTP
id 700C237B946; Thu, 20 Jul 2000 09:31:27 -0700 (PDT)
(envelope-from brian@Awfulhak.org)
Received: from hak.lan.Awfulhak.org (hak.nat.Awfulhak.org [172.31.0.12])
by storm.FreeBSD.org.uk (8.9.3/8.9.3) with ESMTP id RAA81107;
Thu, 20 Jul 2000 17:31:23 +0100 (BST)
(envelope-from brian@Awfulhak.org)
Received: from hak.lan.Awfulhak.org (localhost [127.0.0.1])
by hak.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id RAA03447;
Thu, 20 Jul 2000 17:31:17 +0100 (BST)
(envelope-from brian@hak.lan.Awfulhak.org)
Message-Id: <200007201631.RAA03447@hak.lan.Awfulhak.org>
X-Mailer: exmh version 2.1.1 10/15/1999
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: Brian Somers <brian@Awfulhak.org>,
Jordan Hubbard <jkh@FreeBSD.org>, cvs-committers@FreeBSD.org,
cvs-all@FreeBSD.org, Brian Somers <brian@FreeBSD.org>,
shin@FreeBSD.org, brian@Awfulhak.org
Subject: Re: cvs commit: src/lib/libc/net rcmd.3 rcmd.c
In-Reply-To: Message from Sheldon Hearn <sheldonh@uunet.co.za>
of "Thu, 20 Jul 2000 16:08:07 +0200." <4245.964102087@axl.ops.uunet.co.za>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 20 Jul 2000 17:31:16 +0100
From: Brian Somers <brian@Awfulhak.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG
>
>
> On Thu, 20 Jul 2000 15:01:05 +0100, Brian Somers wrote:
>
> > The alternative would be to bump __FreeBSD_version for this purpose.
> >
> > Whaddaya think ?
>
> >From what I understand of your feedback, it doesn't seem that a version
> bump is going to solve anything for anyone -- neither old code nor new.
> Unless I've gone mad and it's illegal to try to free a NULL pointer. :-)
>
> Oh hang on... When rcmd() and rcmd_af() free the ahost allocations, do
> they set the pointer to NULL afterwards? If not, they should, and then
> we have no problem but the unavoidable memory leaks for old code.
The don't set *ahost to NULL, it remains pointing to the free()d
memory :-(
> Ciao,
> Sheldon.
>
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org> <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message