From owner-cvs-all@FreeBSD.ORG Fri Sep 9 06:37:57 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD68916A41F; Fri, 9 Sep 2005 06:37:57 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7684C43D45; Fri, 9 Sep 2005 06:37:57 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j896ZVdJ037770; Fri, 9 Sep 2005 00:35:31 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 09 Sep 2005 00:36:12 -0600 (MDT) Message-Id: <20050909.003612.99256618.imp@bsdimp.com> To: glebius@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <20050909055930.GM53891@cell.sick.ru> References: <20050908194607.GL53891@cell.sick.ru> <20050908.140057.84363209.imp@bsdimp.com> <20050909055930.GM53891@cell.sick.ru> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 09 Sep 2005 00:35:31 -0600 (MDT) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2005 06:37:58 -0000 In message: <20050909055930.GM53891@cell.sick.ru> Gleb Smirnoff writes: : On Thu, Sep 08, 2005 at 02:00:57PM -0600, M. Warner Losh wrote: : M> : On Thu, Sep 08, 2005 at 05:18:42PM +0000, Warner Losh wrote: : M> : W> imp 2005-09-08 17:18:42 UTC : M> : W> : M> : W> FreeBSD src repository : M> : W> : M> : W> Modified files: : M> : W> sys/dev/pccbb pccbb.c : M> : W> Log: : M> : W> Minor improvement for the suspend case for Ricoh based (and others) : M> : W> CardBus bridges. : M> : : M> : Is this going to fix suspend (broken in mid-July) on APM notebooks? : M> : M> Who knows? I don't have any notebooks that suspend/resume correctly, : M> so I can't tell you. Sorry. Take your chances and find out, or find : M> someone who has the time to fix the other suspend/resume problems on : M> my laptops. Thanks! : : Warner, the fact is that the suspend used to work. Since two months passed : and the regression is not fixed, I will insist on backout. I don't believe : that the discussed commit brings a feature so important that we can stand : suspend being broken. I humbly disagree. This is current, and one of the basic concepts of current is that things break. I've been working to get a laptop that has an otherwise working suspend/resume to test with. However, until that happens, it will remain broken, and remain in current. If we get close to a release, then I'll think about backing it out. I've tried three different laptops, and all of them have other problems that are getting in the way. The power stuff really does help a *lot*. I no longer have characters eaten when I insert a card. The sound doesn't glitch, the cards come up much faster than before. It is a really important feature that I want to see widespread testing on. I'm sorry that we disagree here. Warner