From owner-svn-src-all@FreeBSD.ORG  Tue Oct 19 22:10:07 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 621FE106566B;
	Tue, 19 Oct 2010 22:10:07 +0000 (UTC)
	(envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3])
	by mx1.freebsd.org (Postfix) with ESMTP id 139F98FC17;
	Tue, 19 Oct 2010 22:10:07 +0000 (UTC)
Received: from localhost (amavis.fra.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 6F6C541C75D;
	Wed, 20 Oct 2010 00:10:06 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([192.168.74.103])
	by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id cvyqk79tI9ox; Wed, 20 Oct 2010 00:10:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id AC1CB41C75C; Wed, 20 Oct 2010 00:10:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id BA6604448F3;
	Tue, 19 Oct 2010 22:06:09 +0000 (UTC)
Date: Tue, 19 Oct 2010 22:06:09 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: Bernhard Schmidt <bschmidt@FreeBSD.org>
In-Reply-To: <201010191911.o9JJBaQe024210@svn.freebsd.org>
Message-ID: <20101019220455.D46881@maildrop.int.zabbadoz.net>
References: <201010191911.o9JJBaQe024210@svn.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r214070 - head/sys/dev/if_ndis
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Oct 2010 22:10:07 -0000

On Tue, 19 Oct 2010, Bernhard Schmidt wrote:

> Author: bschmidt
> Date: Tue Oct 19 19:11:36 2010
> New Revision: 214070
> URL: http://svn.freebsd.org/changeset/base/214070
>
> Log:
>  There is no reason to call rt_ifmsg(), remove it.

While it's indeed very uncommon to have that in a driver, I don't know
how much black magic if_ndis(4) is.  Have you verified that you still
get the events from elsewhere on the routing socket when
loading/unloading if_ndif.ko?


>  Submitted by:	Paul B Mahol <onemda at gmail.com>
>  MFC after:	1 week
>
> Modified:
>  head/sys/dev/if_ndis/if_ndis.c
>
> Modified: head/sys/dev/if_ndis/if_ndis.c
> ==============================================================================
> --- head/sys/dev/if_ndis/if_ndis.c	Tue Oct 19 18:49:26 2010	(r214069)
> +++ head/sys/dev/if_ndis/if_ndis.c	Tue Oct 19 19:11:36 2010	(r214070)
> @@ -1644,10 +1644,6 @@ ndis_linksts_done(adapter)
> 	default:
> 		break;
> 	}
> -
> -	/* Notify possible listners of interface change. */
> -
> -	rt_ifmsg(ifp);
> }
>
> static void
>

-- 
Bjoern A. Zeeb                              Welcome a new stage of life.