From owner-cvs-all@FreeBSD.ORG Sat Jun 14 12:44:57 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB1291065678; Sat, 14 Jun 2008 12:44:57 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail5out.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) by mx1.freebsd.org (Postfix) with ESMTP id 6100B8FC0C; Sat, 14 Jun 2008 12:44:56 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by mail5out.barnet.com.au (Postfix, from userid 1001) id 19AA42218991; Sat, 14 Jun 2008 22:44:56 +1000 (EST) X-Viruscan-Id: <4853BD4700000BA2C1CA99@BarNet> Received: from mail5auth.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail5auth.barnet.com.au", Issuer "*.barnet.com.au" (verified OK)) by mail5.barnet.com.au (Postfix) with ESMTP id CC59E21B2C80; Sat, 14 Jun 2008 22:44:55 +1000 (EST) Received: from k7.mavetju (k7.mavetju.org [10.251.1.18]) by mail5auth.barnet.com.au (Postfix) with ESMTP id 7E5642218808; Sat, 14 Jun 2008 22:44:55 +1000 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 0603F4DD; Sat, 14 Jun 2008 22:44:53 +1000 (EST) Date: Sat, 14 Jun 2008 22:44:53 +1000 From: Edwin Groothuis To: Marcin Cieslak Message-ID: <20080614124453.GF89632@k7.mavetju> References: <200806132211.m5DMBONf038311@repoman.freebsd.org> <48532AFC.4030004@SYSTEM.PL> <4853BABC.2040500@SYSTEM.PL> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4853BABC.2040500@SYSTEM.PL> User-Agent: Mutt/1.4.2.3i Cc: Jeremy Messenger , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/tn5250j Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2008 12:44:58 -0000 On Sat, Jun 14, 2008 at 02:34:04PM +0200, Marcin Cieslak wrote: > Jeremy Messenger wrote: > >On Fri, 13 Jun 2008 21:20:44 -0500, Marcin Cieslak wrote: > > > >>Jeremy Messenger wrote: > >>>Do that need to be check careful. I rather to avoid use ${BUILD_DEPENDS} > >>>and do the copy-n-paste full lines instead. Are zip and ant need to be > >>>in the runtime dependency? The ${BUILD_DEPENDS} causes USE_*=yes to be > >>>include in the runtime dependency. > >> > >>No, zip is needed only to unpack the distfile, ant is only needed to > >>build the stuff (it's just like "make"). > > > ># make run-depends-list | grep ant > >/usr/ports/devel/apache-ant > > > > That's exactly the reason why RUN_DEPENDS= ${BUILD_DEPENDS} is wrong :-( > Thanks for pointing out. > > There I would propose another patch: Let me know once there is deviced on something, and then send-pr it with a CC to me. (That's the simplest way to make sure I do the right one) Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/