From owner-svn-src-head@FreeBSD.ORG Sat Jul 13 20:27:48 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3804C6EE; Sat, 13 Jul 2013 20:27:48 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lb0-x233.google.com (mail-lb0-x233.google.com [IPv6:2a00:1450:4010:c04::233]) by mx1.freebsd.org (Postfix) with ESMTP id E6CF41EE4; Sat, 13 Jul 2013 20:27:46 +0000 (UTC) Received: by mail-lb0-f179.google.com with SMTP id w20so8512786lbh.10 for ; Sat, 13 Jul 2013 13:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=SOhl3HR5RaWQyAodkD7rJ8u6JalJJuUILTV4jJJvv5k=; b=m4S3udELA2SeUOx5y6j1z3b5CxCW91fjnX9jybfjtmv6CYkbb9ebKJQt+DWlLnUxlk YvtOAmRjFN7+nfHN7o7ZVpMvk0et9ddxF5kYjD9dRiQm1VKpvM1w5445wz6zxqS8ne8m Zp+FdOIHTyxcZXURm0EWMxsHbdNoN1YTWgbfsJw55v3PaZK91CMajtRRnnpl7xBhW06e SDG2C3u8k3duDPZlsHyMnbBdxRMHkyiK/mLXslXc3eXBPCvm/8YPHVBiBM1MC2eM9djI jnCb69y0u8JxyybNwQgz+vyDbSRD/40fwjcgfhEG77ql2/1M+d9GAvNJ2/YhxKFdLp7X 0kdw== X-Received: by 10.112.180.164 with SMTP id dp4mr21661574lbc.68.1373747265719; Sat, 13 Jul 2013 13:27:45 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id e5sm15907388lbw.3.2013.07.13.13.27.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 13:27:44 -0700 (PDT) Sender: Mikolaj Golub Date: Sat, 13 Jul 2013 23:27:42 +0300 From: Mikolaj Golub To: Craig Rodrigues Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713202741.GB2832@gmail.com> References: <20130713073118.GC2757@gmail.com> <20130713111825.GE2757@gmail.com> <20130713141802.GG2757@gmail.com> <20130713183354.GA2832@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd , src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 20:27:48 -0000 On Sat, Jul 13, 2013 at 12:45:13PM -0700, Craig Rodrigues wrote: > OK, just to double check, based on reading your post: > http://lists.freebsd.org/pipermail/svn-src-all/2013-July/071848.html , > with Marko's kldload/kldunload change, you encountered kernel panics in PF > and IPFW? Yes. Also in lagg :( > I also encountered kernel panics in PF with that patch. > Maybe we can clean up those modules in a separate pass, > and apply the kldload/kldunload fix some time in the future. > > > > > > > > Concerning your combined patch, as I said previously I don't like very > > much that dance with is_default_vnet. What is a purpose of it? As for > > me, it only makes the code less readable. I would just set curvnet to > > vnet0, as it is in Marko's patch. > > > > Fine by me. I have re-rolled my combined patch to remove the > is_default_vnet check > and go with Marko's code to set curvnet to vnet0: > > (1) Combine Adrian and Marko's patches, but omit Marko's changes to > kldload/kldunload: > > http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko-p2.txt > > (2) Revert my Bluetooth patch: > > http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt Thanks. -- Mikolaj Golub